Closed Bug 1394820 Opened 5 years ago Closed 5 years ago

Enable ESLint for DownloadIntegration.jsm

Categories

(Firefox :: Downloads Panel, enhancement)

Product:
Firefox
Component:
Downloads Panel
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: standard8, Assigned: dbugs)

References

Details

Attachments

(1 file)

Bug 1394820 - Enable ESLint for DownloadIntegration.jsm
59 bytes, text/x-review-board-request
standard8
: review+
Details 
Bug 1384038 has removed the preprocessing from toolkit/components/jsdownloads/src/DownloadIntegration.jsm, hence we can now run ESLint on it to reduce potential for errors.

Todo:

- Remove the reference from .eslintignore
- Fix the issues raised by running ESLint on the file.
Comment on attachment 8902346 [details]
Bug 1394820 - Enable ESLint for DownloadIntegration.jsm

https://reviewboard.mozilla.org/r/173894/#review179200

Looks great, r=Standard8
Attachment #8902346 - Flags: review?(standard8) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/341d93b956be
Enable ESLint for DownloadIntegration.jsm r=standard8
https://hg.mozilla.org/mozilla-central/rev/341d93b956be
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.