Closed
Bug 1394849
Opened 7 years ago
Closed 7 years ago
Shorthand for generating stacktrace
Categories
(Remote Protocol :: Marionette, enhancement)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(2 files)
To ease the pain of generating sensible stacktraces we should introduce an error.stack() function. At random locations around Marionette we want it to be easy to generate stacktraces that make sense, instead of having to enter "new Error().stack.toString()" every time. There are places where we will want to log stacktraces as part of log warnings or errors, and having an error.stack() API available would be more terse. Furthermore, I need this as a dependency to https://bugzil.la/marionette-window-tracking.
Assignee | ||
Updated•7 years ago
|
Blocks: marionette-window-tracking
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8902314 [details] Bug 1394849 - Add error.stack to create stacktraces. https://reviewboard.mozilla.org/r/173852/#review179240
Attachment #8902314 -
Flags: review?(dburns) → review+
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8902313 [details] Bug 1394849 - Export pprint separately. https://reviewboard.mozilla.org/r/173850/#review179248 There are a number of failures on try about this so will review when it has been updated
Attachment #8902313 -
Flags: review?(dburns) → review-
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8902313 [details] Bug 1394849 - Export pprint separately. https://reviewboard.mozilla.org/r/173850/#review179696 ::: testing/marionette/test_error.js:148 (Diff revision 2) > > run_next_test(); > }); > > +/* > +add_test(function test_stack() { This should be on the other commit which just removes the comment line
Attachment #8902313 -
Flags: review?(dburns) → review+
Assignee | ||
Comment 8•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8902313 [details] Bug 1394849 - Export pprint separately. https://reviewboard.mozilla.org/r/173850/#review179696 > This should be on the other commit which just removes the comment line Sorry about that. I was trying to stage this in a clever way. This shouldn’t be part of the first commit.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 11•7 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/62a7518223be Export pprint separately. r=automatedtester https://hg.mozilla.org/integration/autoland/rev/6d66d3b4226c Add error.stack to create stacktraces. r=automatedtester
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/62a7518223be https://hg.mozilla.org/mozilla-central/rev/6d66d3b4226c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•