139492 - Crash [@nsChromeTreeOwner::SetEnabled] continuing from venkman caught exception after closing the window it was debugging

Status: RESOLVED WONTFIX

(Core :: XUL, defect)

Description

[timeless]

#0  0x28b69371 in nsChromeTreeOwner::SetEnabled (this=0x85afd00, aEnable=1) at /home/timeless/wgate/mozilla/xpfe/appshell/src/nsChromeTreeOwner.cpp:308
308        return mXULWindow->SetEnabled(aEnable);
(gdb) p mXULWindow
$1 = (nsXULWindow *) 0x0
(gdb) where
#0  0x28b69371 in nsChromeTreeOwner::SetEnabled (this=0x85afd00, aEnable=1) at /home/timeless/wgate/mozilla/xpfe/appshell/src/nsChromeTreeOwner.cpp:308
#1  0x282fe09e in XPTC_InvokeByIndex (that=0x85afd04, methodIndex=20, paramCount=1, params=0xbfbfb338)
    at /home/timeless/wgate/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_unixish_x86.cpp:130
#2  0x28904565 in XPCWrappedNative::CallMethod (ccx=@0xbfbfb430, mode=CALL_SETTER) at /home/timeless/wgate/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp:2025
#3  0x289221ce in XPCWrappedNative::SetAttribute (ccx=@0xbfbfb430) at /home/timeless/wgate/mozilla/js/src/xpconnect/src/xpcprivate.h:1826
#4  0x2890d99e in XPC_WN_GetterSetter (cx=0x857c000, obj=0x88fa828, argc=1, argv=0x90371c0, vp=0xbfbfb564) at /home/timeless/wgate/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp:1290
#5  0x2817b112 in js_Invoke (cx=0x857c000, argc=1, flags=2) at /home/timeless/wgate/mozilla/js/src/jsinterp.c:788
#6  0x2817b507 in js_InternalInvoke (cx=0x857c000, obj=0x88fa828, fval=143632952, flags=0, argc=1, argv=0xbfbfbf90, rval=0xbfbfbf90) at /home/timeless/wgate/mozilla/js/src/jsinterp.c:880
#7  0x2819de23 in js_SetProperty (cx=0x857c000, obj=0x88fa828, id=135242496, vp=0xbfbfbf90) at /home/timeless/wgate/mozilla/js/src/jsobj.c:2665
#8  0x281885c3 in js_Interpret (cx=0x857c000, result=0xbfbfc080) at /home/timeless/wgate/mozilla/js/src/jsinterp.c:2587
#9  0x2817b190 in js_Invoke (cx=0x857c000, argc=3, flags=2) at /home/timeless/wgate/mozilla/js/src/jsinterp.c:805
#10 0x288fcb1b in nsXPCWrappedJSClass::CallMethod (this=0x86571c0, wrapper=0x8657200, methodIndex=3, info=0x8437af0, nativeParams=0xbfbfc61c)
    at /home/timeless/wgate/mozilla/js/src/xpconnect/src/xpcwrappedjsclass.cpp:1193
#11 0x288f672a in nsXPCWrappedJS::CallMethod (this=0x8657200, methodIndex=3, info=0x8437af0, params=0xbfbfc61c) at /home/timeless/wgate/mozilla/js/src/xpconnect/src/xpcwrappedjs.cpp:429
#12 0x282fe51a in PrepareAndDispatch (self=0x8657200, methodIndex=3, args=0xbfbfc6f4) at /home/timeless/wgate/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_unixish_x86.cpp:95
#13 0x282fe5e3 in nsXPTCStubBase::Stub3 (this=0x8657200) at ../../../../../../dist/include/xpcom/xptcstubsdef.inc:5
#14 0x2a4aba8f in jsds_ExecutionHookProc (jsdc=0x831fc00, jsdthreadstate=0x8c31e60, type=4, callerdata=0x0, rval=0xbfbfd11c) at /home/timeless/wgate/mozilla/js/jsd/jsd_xpc.cpp:663
#15 0x2a4a27c4 in jsd_CallExecutionHook (jsdc=0x831fc00, cx=0x857c000, type=4, hook=0x2a4ab608 <jsds_ExecutionHookProc(JSDContext *, JSDThreadState *, unsigned int, void *, long *)>,
    hookData=0x0, rval=0xbfbfd11c) at /home/timeless/wgate/mozilla/js/jsd/jsd_hook.c:167
#16 0x2a4a2745 in jsd_ThrowHandler (cx=0x857c000, script=0x8e0a200, pc=0x8e0a254 ":", rval=0xbfbfd11c, closure=0x831fc00) at /home/timeless/wgate/mozilla/js/jsd/jsd_hook.c:148
#17 0x2818f060 in js_Interpret (cx=0x857c000, result=0xbfbfd20c) at /home/timeless/wgate/mozilla/js/src/jsinterp.c:3891
#18 0x2817b190 in js_Invoke (cx=0x857c000, argc=1, flags=2) at /home/timeless/wgate/mozilla/js/src/jsinterp.c:805
#19 0x2817b507 in js_InternalInvoke (cx=0x857c000, obj=0x8902f50, fval=143667040, flags=0, argc=1, argv=0xbfbfd6f0, rval=0xbfbfd3d4) at /home/timeless/wgate/mozilla/js/src/jsinterp.c:880
#20 0x28149d11 in JS_CallFunctionValue (cx=0x857c000, obj=0x8902f50, fval=143667040, argc=1, argv=0xbfbfd6f0, rval=0xbfbfd3d4) at /home/timeless/wgate/mozilla/js/src/jsapi.c:3412
#21 0x2907a3d8 in nsJSContext::CallEventHandler (this=0x85b05c0, aTarget=0x8902f50, aHandler=0x8902f60, argc=1, argv=0xbfbfd6f0, aBoolResult=0xbfbfd510, aReverseReturnResult=0)
    at /home/timeless/wgate/mozilla/dom/src/base/nsJSEnvironment.cpp:1015
#22 0x290c702f in nsJSEventListener::HandleEvent (this=0x8dce020, aEvent=0x8d8bd88) at /home/timeless/wgate/mozilla/dom/src/events/nsJSEventListener.cpp:180
#23 0x29321bc1 in nsEventListenerManager::HandleEventSubType (this=0x8dd9bc0, aListenerStruct=0x8d91ae0, aDOMEvent=0x8d8bd88, aCurrentTarget=0x8dd9c08, aSubType=8, aPhaseFlags=7)
    at /home/timeless/wgate/mozilla/content/events/src/nsEventListenerManager.cpp:1217
#24 0x29325c4c in nsEventListenerManager::HandleEvent (this=0x8dd9bc0, aPresContext=0x8d79400, aEvent=0xbfbfe5d4, aDOMEvent=0xbfbfe434, aCurrentTarget=0x8dd9c08, aFlags=7, aEventStatus=0xbfbfe5cc)
    at /home/timeless/wgate/mozilla/content/events/src/nsEventListenerManager.cpp:2207
#25 0x294b3f30 in nsXULElement::HandleDOMEvent (this=0x8dd9c00, aPresContext=0x8d79400, aEvent=0xbfbfe5d4, aDOMEvent=0xbfbfe434, aFlags=1, aEventStatus=0xbfbfe5cc)
    at /home/timeless/wgate/mozilla/content/xul/content/src/nsXULElement.cpp:3460
#26 0x29c5abd6 in PresShell::HandleDOMEventWithTarget (this=0x8d79800, aTargetContent=0x8dd9c00, aEvent=0xbfbfe5d4, aStatus=0xbfbfe5cc)
    at /home/timeless/wgate/mozilla/layout/html/base/src/nsPresShell.cpp:6141
#27 0x29d598fb in nsButtonBoxFrame::MouseClicked (this=0x8e7beb4, aPresContext=0x8d79400, aEvent=0xbfbfe90c) at /home/timeless/wgate/mozilla/layout/xul/base/src/nsButtonBoxFrame.cpp:191
#28 0x29d5933f in nsButtonBoxFrame::HandleEvent (this=0x8e7beb4, aPresContext=0x8d79400, aEvent=0xbfbfe90c, aEventStatus=0xbfbfee58)
    at /home/timeless/wgate/mozilla/layout/xul/base/src/nsButtonBoxFrame.cpp:138
#29 0x29c5a9f6 in PresShell::HandleEventInternal (this=0x8d79800, aEvent=0xbfbfe90c, aView=0x0, aFlags=1, aStatus=0xbfbfee58)
    at /home/timeless/wgate/mozilla/layout/html/base/src/nsPresShell.cpp:6109
#30 0x29c5a66e in PresShell::HandleEventWithTarget (this=0x8d79800, aEvent=0xbfbfe90c, aFrame=0x8e7beb4, aContent=0x8da4e00, aFlags=1, aStatus=0xbfbfee58)
    at /home/timeless/wgate/mozilla/layout/html/base/src/nsPresShell.cpp:6063
#31 0x29333380 in nsEventStateManager::CheckForAndDispatchClick (this=0x8e21300, aPresContext=0x8d79400, aEvent=0xbfbff190, aStatus=0xbfbfee58)
    at /home/timeless/wgate/mozilla/content/events/src/nsEventStateManager.cpp:2623
#32 0x2932ffcc in nsEventStateManager::PostHandleEvent (this=0x8e21300, aPresContext=0x8d79400, aEvent=0xbfbff190, aTargetFrame=0x8e7beb4, aStatus=0xbfbfee58, aView=0x8d67a80)
    at /home/timeless/wgate/mozilla/content/events/src/nsEventStateManager.cpp:1705
#33 0x29c5aa69 in PresShell::HandleEventInternal (this=0x8d79800, aEvent=0xbfbff190, aView=0x8d67a80, aFlags=1, aStatus=0xbfbfee58)
    at /home/timeless/wgate/mozilla/layout/html/base/src/nsPresShell.cpp:6114
#34 0x29c5a2c5 in PresShell::HandleEvent (this=0x8d79800, aView=0x8d67a80, aEvent=0xbfbff190, aEventStatus=0xbfbfee58, aForceHandle=1, aHandled=@0xbfbfedf0)
    at /home/timeless/wgate/mozilla/layout/html/base/src/nsPresShell.cpp:6017
#35 0x29ff1ecf in nsViewManager::HandleEvent (this=0x8cf0500, aView=0x8d67a80, aEvent=0xbfbff190, aCaptured=1) at /home/timeless/wgate/mozilla/view/src/nsViewManager.cpp:2074
#36 0x29fe21dd in nsView::HandleEvent (this=0x8d67a80, aVM=0x8cf0500, aEvent=0xbfbff190, aCaptured=1) at /home/timeless/wgate/mozilla/view/src/nsView.cpp:305
#37 0x29ff1525 in nsViewManager::DispatchEvent (this=0x8cf0500, aEvent=0xbfbff190, aStatus=0xbfbfefe4) at /home/timeless/wgate/mozilla/view/src/nsViewManager.cpp:1881
#38 0x29fe188e in HandleEvent (aEvent=0xbfbff190) at /home/timeless/wgate/mozilla/view/src/nsView.cpp:80
#39 0x28bfe1fc in nsWidget::DispatchEvent (this=0x857cc00, aEvent=0xbfbff190, aStatus=@0xbfbff0d4) at /home/timeless/wgate/mozilla/widget/src/gtk/nsWidget.cpp:1483
#40 0x28bfdd8d in nsWidget::DispatchWindowEvent (this=0x857cc00, event=0xbfbff190) at /home/timeless/wgate/mozilla/widget/src/gtk/nsWidget.cpp:1371
#41 0x28bfe2f3 in nsWidget::DispatchMouseEvent (this=0x857cc00, aEvent=@0xbfbff190) at /home/timeless/wgate/mozilla/widget/src/gtk/nsWidget.cpp:1510
#42 0x28bff9e6 in nsWidget::OnButtonReleaseSignal (this=0x857cc00, aGdkButtonEvent=0x829b018) at /home/timeless/wgate/mozilla/widget/src/gtk/nsWidget.cpp:2072
#43 0x28c05dca in nsWindow::HandleGDKEvent (this=0x857cc00, event=0x829b018) at /home/timeless/wgate/mozilla/widget/src/gtk/nsWindow.cpp:1590
#44 0x28bf527c in dispatch_superwin_event (event=0x829b018, window=0x857cc00) at /home/timeless/wgate/mozilla/widget/src/gtk/nsGtkEventHandler.cpp:970
#45 0x28bf4e50 in handle_gdk_event (event=0x829b018, data=0x0) at /home/timeless/wgate/mozilla/widget/src/gtk/nsGtkEventHandler.cpp:836
#46 0x2852c8ec in gdk_event_dispatch () from /usr/X11R6/lib/libgdk12.so.2
#47 0x2855ad03 in g_main_dispatch () from /usr/local/lib/libglib12.so.3
#48 0x2855b32c in g_main_iterate () from /usr/local/lib/libglib12.so.3
#49 0x2855b4c4 in g_main_run () from /usr/local/lib/libglib12.so.3
#50 0x2847b8b7 in gtk_main () from /usr/X11R6/lib/libgtk12.so.2
#51 0x28bea7fd in nsAppShell::Run (this=0x80e1550) at /home/timeless/wgate/mozilla/widget/src/gtk/nsAppShell.cpp:364
#52 0x28b78d89 in nsAppShellService::Run (this=0x812c580) at /home/timeless/wgate/mozilla/xpfe/appshell/src/nsAppShellService.cpp:308
#53 0x0805f6c4 in main1 (argc=4, argv=0xbfbff83c, nativeApp=0x0) at /home/timeless/wgate/mozilla/xpfe/bootstrap/nsAppRunner.cpp:1467
#54 0x0806056d in main (argc=4, argv=0xbfbff83c) at /home/timeless/wgate/mozilla/xpfe/bootstrap/nsAppRunner.cpp:1820
#55 0x08058415 in _start ()

Comment 1

[timeless]

the fix is easy, i just need to pick a good error value.

Comment 2

[timeless]

Attachment: patch - null check and remove 3space indentation.

Comment 3

[timeless]

Attachment: same patch; -w1 for review

Comment 4

[Adam Lock]

-> XUL for review

Comment 5

[Adam Lock]

Reassign. Looking for review

Comment 6

[[e-mail]]

Comment on attachment 80839 [details] [diff] [review]
same patch; -w1 for review

Patch is unreadable.

Comment 7

[Robert Kaiser]

Neil, is this still relevant? We're not seeing that signature around but venkman is not used that much. If it's not relevant any more, we'd like to close it to reduce the list of open crash bugs.

Comment 8

[[e-mail]]

It might be possible to duplicate this crash using the new devtools debugger, if it tries to disable the window being debugged (will it debug chrome?)

Comment 9

[Robert Kaiser]

(In reply to [e-mail] from comment #8)
> It might be possible to duplicate this crash using the new devtools
> debugger, if it tries to disable the window being debugged (will it debug
> chrome?)

AFAIK, the devtools debugger can't debug chrome right now. Also, it uses jsdebug2 and is written a lot differently.

That said, venkman still exists, can you try if it still exposes this problem?

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Closing because no crash reported since 12 weeks.