Closed Bug 1394947 Opened 5 years ago Closed 5 years ago

sidebar menus only show, does not toggle extension sidebars

Categories

(WebExtensions :: Frontend, defect, P3)

Product:
WebExtensions
Component:
Frontend
Platform:
x86_64
macOS
Type:
defect

Tracking

(firefox55 wontfix, firefox56 affected, firefox57 verified)

Status:
VERIFIED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox55 --- wontfix
firefox56 --- affected
firefox57 --- verified

People

(Reporter: wcosta, Assigned: mixedpuppy)

References

Details

User Story

See bug 1387054 comment 5 for context.

Attachments

(2 files)

Bug 1394947 fix toggling the extension sidebars from menus,
59 bytes, text/x-review-board-request
Gijs
: review+
Details
tabreduxopen.gif
1.28 MB, image/gif
Details 
+++ This bug was initially created as a clone of Bug #1387054 +++
Component: Extension Compatibility → WebExtensions: Frontend
Priority: -- → P3
Product: Firefox → Toolkit
When moving to the new sidebar selector menu (bug 1365637) I changed the command to use SidebarUI.show rather than SidebarUI.toggle.  Need to simply change that back (iirc at first the new menu did not toggle).
Blocks: 1365637
Summary: Disabling sidebar doesn't work on nightly → view->sidebar->extension sidebar menu only shows, does not toggle
Summary: view->sidebar->extension sidebar menu only shows, does not toggle → sidebar menus only show, does not toggle extension sidebars
Assignee: nobody → mixedpuppy
Comment on attachment 8906804 [details]
Bug 1394947 fix toggling the extension sidebars from menus,

Going to give this to Gijs since he reviewed the original change.
Attachment #8906804 - Flags: review?(tomica) → review?(gijskruitbosch+bugs)
Comment on attachment 8906804 [details]
Bug 1394947 fix toggling the extension sidebars from menus,

https://reviewboard.mozilla.org/r/178528/#review183700
Attachment #8906804 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0ad97b0a82c4
fix toggling the extension sidebars from menus, r=Gijs
https://hg.mozilla.org/mozilla-central/rev/0ad97b0a82c4
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Attached image tabreduxopen.gif — 
Issue reproduced on Firefox 57.0a1 (20170828100127) under Wind 10 64-bit. 

This issue is verified as fixed on Firefox 57.0 (20171112125346), Firefox 58.0b3 (20171113130450) and 59.0a1 (20171113220112) under Wind 10 64-bit and Mac OS X 10.13.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.