Closed
Bug 1394947
Opened 5 years ago
Closed 5 years ago
sidebar menus only show, does not toggle extension sidebars
Categories
(WebExtensions :: Frontend, defect, P3)
Tracking
(firefox55 wontfix, firefox56 affected, firefox57 verified)
VERIFIED
FIXED
mozilla57
People
(Reporter: wcosta, Assigned: mixedpuppy)
References
Details
User Story
See bug 1387054 comment 5 for context.
Attachments
(2 files)
+++ This bug was initially created as a clone of Bug #1387054 +++
Updated•5 years ago
|
Component: Extension Compatibility → WebExtensions: Frontend
Priority: -- → P3
Product: Firefox → Toolkit
Assignee | ||
Comment 1•5 years ago
|
||
When moving to the new sidebar selector menu (bug 1365637) I changed the command to use SidebarUI.show rather than SidebarUI.toggle. Need to simply change that back (iirc at first the new menu did not toggle).
Blocks: 1365637
Summary: Disabling sidebar doesn't work on nightly → view->sidebar->extension sidebar menu only shows, does not toggle
Assignee | ||
Updated•5 years ago
|
Summary: view->sidebar->extension sidebar menu only shows, does not toggle → sidebar menus only show, does not toggle extension sidebars
Comment hidden (mozreview-request) |
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → mixedpuppy
Assignee | ||
Comment 3•5 years ago
|
||
Comment on attachment 8906804 [details] Bug 1394947 fix toggling the extension sidebars from menus, Going to give this to Gijs since he reviewed the original change.
Attachment #8906804 -
Flags: review?(tomica) → review?(gijskruitbosch+bugs)
Assignee | ||
Updated•5 years ago
|
status-firefox55:
--- → wontfix
status-firefox56:
--- → affected
Comment 4•5 years ago
|
||
mozreview-review |
Comment on attachment 8906804 [details] Bug 1394947 fix toggling the extension sidebars from menus, https://reviewboard.mozilla.org/r/178528/#review183700
Attachment #8906804 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by mixedpuppy@gmail.com: https://hg.mozilla.org/integration/autoland/rev/0ad97b0a82c4 fix toggling the extension sidebars from menus, r=Gijs
![]() |
||
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0ad97b0a82c4
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 7•5 years ago
|
||
Issue reproduced on Firefox 57.0a1 (20170828100127) under Wind 10 64-bit. This issue is verified as fixed on Firefox 57.0 (20171112125346), Firefox 58.0b3 (20171113130450) and 59.0a1 (20171113220112) under Wind 10 64-bit and Mac OS X 10.13.
Updated•5 years ago
|
Status: RESOLVED → VERIFIED
Updated•4 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•