1394987 - stylo: Print preview doesn't flush styles before calling into the frame constructor

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Bobby Holley (:bholley)]

I discovered this while debugging bug 1390951. We end up with a snapshot on the element, and then we print preview before flushing styles. This causes us to assert about stale style from the frame constructor.

The fix is just to flush styles in PresShell::ReconstructFrames. It's a bit wasteful to compute and handle the change hints, but print preview isn't hot.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Remove dead codepath into PresShell::ReconstructFrames. r=emilio

Emilio r+ed this on IRC.

MozReview-Commit-ID: 5ZqvGc2eTmJ

Comment 2

[Bobby Holley (:bholley)]

Attachment: Flush styles in PresShell::ReconstructFrames. r=emilio

MozReview-Commit-ID: GUuE1dKoDvK

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44cf79f64669
Remove dead codepath into PresShell::ReconstructFrames. r=emilio
https://hg.mozilla.org/integration/autoland/rev/424f755ae73e
Flush styles in PresShell::ReconstructFrames. r=emilio

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/44cf79f64669
https://hg.mozilla.org/mozilla-central/rev/424f755ae73e