Closed Bug 1394987 Opened 3 years ago Closed 3 years ago
stylo: Print preview doesn't flush styles before calling into the frame constructor
I discovered this while debugging bug 1390951. We end up with a snapshot on the element, and then we print preview before flushing styles. This causes us to assert about stale style from the frame constructor. The fix is just to flush styles in PresShell::ReconstructFrames. It's a bit wasteful to compute and handle the change hints, but print preview isn't hot.
Emilio r+ed this on IRC. MozReview-Commit-ID: 5ZqvGc2eTmJ
Attachment #8902469 - Flags: review+
Attachment #8902471 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/44cf79f64669 Remove dead codepath into PresShell::ReconstructFrames. r=emilio https://hg.mozilla.org/integration/autoland/rev/424f755ae73e Flush styles in PresShell::ReconstructFrames. r=emilio
You need to log in before you can comment on or make changes to this bug.