Closed Bug 1394987 Opened 3 years ago Closed 3 years ago

stylo: Print preview doesn't flush styles before calling into the frame constructor

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(2 files)

I discovered this while debugging bug 1390951. We end up with a snapshot on the element, and then we print preview before flushing styles. This causes us to assert about stale style from the frame constructor.

The fix is just to flush styles in PresShell::ReconstructFrames. It's a bit wasteful to compute and handle the change hints, but print preview isn't hot.
Emilio r+ed this on IRC.

MozReview-Commit-ID: 5ZqvGc2eTmJ
Attachment #8902469 - Flags: review+
MozReview-Commit-ID: GUuE1dKoDvK
Attachment #8902471 - Flags: review+
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44cf79f64669
Remove dead codepath into PresShell::ReconstructFrames. r=emilio
https://hg.mozilla.org/integration/autoland/rev/424f755ae73e
Flush styles in PresShell::ReconstructFrames. r=emilio
https://hg.mozilla.org/mozilla-central/rev/44cf79f64669
https://hg.mozilla.org/mozilla-central/rev/424f755ae73e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.