stylo: Print preview doesn't flush styles before calling into the frame constructor

RESOLVED FIXED in Firefox 57

Status

()

P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

a year ago
I discovered this while debugging bug 1390951. We end up with a snapshot on the element, and then we print preview before flushing styles. This causes us to assert about stale style from the frame constructor.

The fix is just to flush styles in PresShell::ReconstructFrames. It's a bit wasteful to compute and handle the change hints, but print preview isn't hot.
(Assignee)

Comment 1

a year ago
Created attachment 8902469 [details] [diff] [review]
Remove dead codepath into PresShell::ReconstructFrames. r=emilio

Emilio r+ed this on IRC.

MozReview-Commit-ID: 5ZqvGc2eTmJ
Attachment #8902469 - Flags: review+
(Assignee)

Comment 2

a year ago
Created attachment 8902471 [details] [diff] [review]
Flush styles in PresShell::ReconstructFrames. r=emilio

MozReview-Commit-ID: GUuE1dKoDvK
Attachment #8902471 - Flags: review+

Comment 3

a year ago
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44cf79f64669
Remove dead codepath into PresShell::ReconstructFrames. r=emilio
https://hg.mozilla.org/integration/autoland/rev/424f755ae73e
Flush styles in PresShell::ReconstructFrames. r=emilio
https://hg.mozilla.org/mozilla-central/rev/44cf79f64669
https://hg.mozilla.org/mozilla-central/rev/424f755ae73e
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.