devtools/server/actors/object.js includes workarounds for resolved bug 1163520

RESOLVED FIXED in Firefox 57

Status

()

Firefox
Developer Tools
P5
minor
RESOLVED FIXED
2 months ago
a month ago

People

(Reporter: jimb, Assigned: jimb)

Tracking

unspecified
Firefox 57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
Created attachment 8902477 [details] [diff] [review]
Remove workaround for bug 1163520.

ObjectActor.prototype.grip in devtools/server/actors/object.js includes workarounds for bug 1163520, which was fixed years ago.
(Assignee)

Comment 1

2 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=39c647593b825f32fa83ed24e0d2f874b2f3ab25
(Assignee)

Comment 2

2 months ago
That try push is not clean, but none of it looks related to this.
(Assignee)

Updated

2 months ago
Attachment #8902477 - Flags: review?(bgrinstead)
Attachment #8902477 - Flags: review?(bgrinstead) → review+
The change is R+'d and the TRY push looks good. Jim, do you want to land this?
Assignee: nobody → jimb
Status: NEW → ASSIGNED
Flags: needinfo?(jimb)
Priority: -- → P5
(Assignee)

Updated

a month ago
Flags: needinfo?(jimb)
Keywords: checkin-needed
(Assignee)

Comment 4

a month ago
Thanks for the ping.

Comment 5

a month ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e6c69e3227c
Remove workaround for bug 1163520. r=bgrins
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4e6c69e3227c
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.