1395021 - Move TrackID definition out of StreamTracks.h

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Having TrackID in StreamTracks.h means that MediaInfo.h, which includes StreamTracks.h, ends up pulling in the MSG and a bunch of DOM bindings code. If we move it out to its own file, we'll get a simpler include graph, at least for the playback code.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1395021 - Move TrackID definition from StreamTracks.h into TrackID.h.

This means that MediaInfo.h doesn't need to include StreamTracks.h, which pulls
in MediaSegment.h and the MSG and a bunch of DOM bindings stuff.

Review commit: https://reviewboard.mozilla.org/r/174100/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174100/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1395021 - Fix up includes to account for StreamTracks.h not being indirectly included in so many places.

With MediaInfo.h no longer including StreamTracks.h, some things that include
MediaInfo.h now use things that are no longer included. This patch adds the
includes back in, so the build works again.

Review commit: https://reviewboard.mozilla.org/r/174102/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174102/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8902515 [details]
Bug 1395021 - Move TrackID definition from StreamTracks.h into TrackID.h.

https://reviewboard.mozilla.org/r/174100/#review179370

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8902516 [details]
Bug 1395021 - Fix up includes to account for StreamTracks.h not being indirectly included in so many places.

https://reviewboard.mozilla.org/r/174102/#review179372

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

It would be easier to detect over/insufficient includes if we build all files under dom/media in non-unified mode.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/620ce0f4d360
Move TrackID definition from StreamTracks.h into TrackID.h. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/1ed072a5827f
Fix up includes to account for StreamTracks.h not being indirectly included in so many places. r=jwwang

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/620ce0f4d360
https://hg.mozilla.org/mozilla-central/rev/1ed072a5827f