1395079 - ./mach build hangs forever when running `watchman version`

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Anthony Ramine [:nox]]

For some reason, `watchman version` never returns on my computer, and thus `mach build` hangs forever. I have watchman 4.9.0 installed through Homebrew.

The command `watchman --version` works just fine.

Comment 1

[Gregory Szorc [:gps]]

This is https://github.com/facebook/watchman/issues/376.

We'll likely want a workaround in configure.

Comment 2

[Gregory Szorc [:gps]]

Attachment: Bug 1395079 - Query version of watchman without using daemon;

See inline comment for why.

We may want a follow-up configure check for whether watchman is
usable (whether we can communicate with the daemon). This can be
deferred to another bug.

Review commit: https://reviewboard.mozilla.org/r/174430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174430/

Comment 3

[Gregory Szorc [:gps]]

nox: please verify the fix.

Comment 4

[Sean Lee [:seanlee][:weilonge]]

Thanks for gps's patch. The patch works for me!

Comment 5

[Michael Shal [:mshal]]

Comment on attachment 8902768 [details]
Bug 1395079 - Query version of watchman without using daemon;

https://reviewboard.mozilla.org/r/174430/#review179980

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e2062e0bc36
Query version of watchman without using daemon; r=mshal

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2e2062e0bc36