1395080 - Don't use nsIDOMRange's method if possible in Editor

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

Except to editor/txtsvc/nsTextServicesDocument.cpp, I would like to replace nsIDOMRange with nsRange.  Ex. nsIDROMRange::GetStartOffset -> nsRange::StartOffset.

nsTextServicesDocument still uses a lot of nsIDOMNode, so this isn't target for it.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1395080 - Part 1. Replace nsIDOMRange::GetCollapsed with nsRange::Collapsed.

Review commit: https://reviewboard.mozilla.org/r/175320/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175320/

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1395080 - Part 2. Replace nsIDOMRange::GetStartOffset and nsIDOMRange::GetEndOffset with nsRange::StartOffset and nsRange::EndOffset.

Review commit: https://reviewboard.mozilla.org/r/175322/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175322/

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1395080 - Part 3. Replace nsIDOMRange::GetStartContainer and nsIDOMRange::GetEndContainer with nsRange::GetStartContainer and nsRange::GetEndContainer.

Except to nsTextServicesDocument.cpp, we replace nsIDOMRange::GetStartContainer and nsIDOMRange::GetEndContainer with nsRange::GetStartContainer and nsRange::GetEndContainer.

Since nsTextServicesDocument.cpp still uses a lot of nsIDOMNode, I will change it by new bug.

Review commit: https://reviewboard.mozilla.org/r/175324/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175324/

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1395080 - Part 4. Remove unused nsIDOMRange parameter.

GetFirstSelectedCell and GetNextSelectedCell allow that 1st parameter is nullptr when current range is unnecessary.  So we should use nullptr when it is unused.

Review commit: https://reviewboard.mozilla.org/r/175326/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175326/

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/8)]

Comment on attachment 8903491 [details]
Bug 1395080 - Part 1. Replace nsIDOMRange::GetCollapsed with nsRange::Collapsed.

https://reviewboard.mozilla.org/r/175320/#review180356

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/8)]

Comment on attachment 8903492 [details]
Bug 1395080 - Part 2. Replace nsIDOMRange::GetStartOffset and nsIDOMRange::GetEndOffset with nsRange::StartOffset and nsRange::EndOffset.

https://reviewboard.mozilla.org/r/175322/#review180360

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/8)]

Comment on attachment 8903493 [details]
Bug 1395080 - Part 3. Replace nsIDOMRange::GetStartContainer and nsIDOMRange::GetEndContainer with nsRange::GetStartContainer and nsRange::GetEndContainer.

https://reviewboard.mozilla.org/r/175324/#review180362

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/8)]

Comment on attachment 8903494 [details]
Bug 1395080 - Part 4. Remove unused nsIDOMRange parameter.

https://reviewboard.mozilla.org/r/175326/#review180364

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/209fa8c3b7b5
Part 1. Replace nsIDOMRange::GetCollapsed with nsRange::Collapsed. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/439080e9a0fc
Part 2. Replace nsIDOMRange::GetStartOffset and nsIDOMRange::GetEndOffset with nsRange::StartOffset and nsRange::EndOffset. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/988b79d9c709
Part 3. Replace nsIDOMRange::GetStartContainer and nsIDOMRange::GetEndContainer with nsRange::GetStartContainer and nsRange::GetEndContainer. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/c1b712be2b72
Part 4. Remove unused nsIDOMRange parameter. r=masayuki

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/209fa8c3b7b5
https://hg.mozilla.org/mozilla-central/rev/439080e9a0fc
https://hg.mozilla.org/mozilla-central/rev/988b79d9c709
https://hg.mozilla.org/mozilla-central/rev/c1b712be2b72