Closed Bug 1395091 Opened 3 years ago Closed 3 years ago

about:telemetry global search should have headings before section results


(Toolkit :: Telemetry, enhancement, P3)




Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- fixed


(Reporter: gfritzsche, Assigned: o0ignition0o, Mentored)




(2 files)

Currently the global search in the about:telemetry homepage does not make clear what section results come from.
We should show labels/headings to make this clear.
This is an item mentioned in bug 1393478. It isn't in the current batch of patches, so maybe this bug's a good chance to break this out a bit? What do you think, flyingrub?
Flags: needinfo?(flyinggrub)
sounds good :)
Flags: needinfo?(flyinggrub)
Jeremy, would you be interested in taking this?
Flags: needinfo?(jeremy.lempereur)
Mentor: chutten
Hey Georg, I would love to !
Flags: needinfo?(jeremy.lempereur)
Attached image global_search.png
Here is an example of what i mean.
I searched for one term and get results from different categories/sections.
Because there are no separate headings, i can't tell which sections the results are actually from. I've put each section into an h1 tag, since I'm not a really great UI designer ^^'
I hope I've covered every corner case, if I haven't please let me know and I'll follow up on this :)
This looks more clear, cheers!
I'll redirect the review to Chris here.
Assignee: nobody → jeremy.lempereur
Attachment #8939689 - Flags: review?(gfritzsche) → review?(chutten)
Great thanks a lot ! If there's an other task you would like me to handle, please tell me. I'm trying to ramp up my js / c++ skills :)
Comment on attachment 8939689 [details]
Bug 1395091 - about:telemetry global search should have headings before section results.

Nice use of modern language features and APIs.
Attachment #8939689 - Flags: review?(chutten) → review+
Pushed by
about:telemetry global search should have headings before section results. r=chutten
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
It's too late for 58, mark 58 won't fix.
You need to log in before you can comment on or make changes to this bug.