about:telemetry global search should have headings before section results

RESOLVED FIXED in Firefox 59

Status

()

P3
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: gfritzsche, Assigned: o0ignition0o, Mentored)

Tracking

(Blocks: 1 bug)

Trunk
mozilla59
Points:
---

Firefox Tracking Flags

(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Currently the global search in the about:telemetry homepage does not make clear what section results come from.
We should show labels/headings to make this clear.
This is an item mentioned in bug 1393478. It isn't in the current batch of patches, so maybe this bug's a good chance to break this out a bit? What do you think, flyingrub?
Flags: needinfo?(flyinggrub)

Comment 2

2 years ago
sounds good :)
Flags: needinfo?(flyinggrub)
(Reporter)

Comment 3

a year ago
Jeremy, would you be interested in taking this?
Flags: needinfo?(jeremy.lempereur)
(Reporter)

Updated

a year ago
Mentor: chutten
(Assignee)

Comment 4

a year ago
Hey Georg, I would love to !
Flags: needinfo?(jeremy.lempereur)
(Reporter)

Comment 5

a year ago
Posted image global_search.png
Cheers!
Here is an example of what i mean.
I searched for one term and get results from different categories/sections.
Because there are no separate headings, i can't tell which sections the results are actually from.
Comment hidden (mozreview-request)
(Assignee)

Comment 7

a year ago
http://ibb.co/iSyLKw I've put each section into an h1 tag, since I'm not a really great UI designer ^^'
I hope I've covered every corner case, if I haven't please let me know and I'll follow up on this :)
(Reporter)

Comment 8

a year ago
This looks more clear, cheers!
I'll redirect the review to Chris here.
(Reporter)

Updated

a year ago
Assignee: nobody → jeremy.lempereur
(Reporter)

Updated

a year ago
Attachment #8939689 - Flags: review?(gfritzsche) → review?(chutten)
(Assignee)

Comment 9

a year ago
Great thanks a lot ! If there's an other task you would like me to handle, please tell me. I'm trying to ramp up my js / c++ skills :)

Comment 10

a year ago
mozreview-review
Comment on attachment 8939689 [details]
Bug 1395091 - about:telemetry global search should have headings before section results.

https://reviewboard.mozilla.org/r/209990/#review215940

Nice use of modern language features and APIs.
Attachment #8939689 - Flags: review?(chutten) → review+

Comment 11

a year ago
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/862df5b1a0c9
about:telemetry global search should have headings before section results. r=chutten

Comment 12

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/862df5b1a0c9
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
It's too late for 58, mark 58 won't fix.
status-firefox57: affected → wontfix
status-firefox58: --- → wontfix
You need to log in before you can comment on or make changes to this bug.