1395091 - about:telemetry global search should have headings before section results

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P3)

Description

[Georg Fritzsche [:gfritzsche]]

Currently the global search in the about:telemetry homepage does not make clear what section results come from.
We should show labels/headings to make this clear.

Comment 1

[Chris H-C :chutten]

This is an item mentioned in bug 1393478. It isn't in the current batch of patches, so maybe this bug's a good chance to break this out a bit? What do you think, flyingrub?

Comment 2

[flyingrub]

sounds good :)

Comment 3

[Georg Fritzsche [:gfritzsche]]

Jeremy, would you be interested in taking this?

Comment 4

[Jeremy Lempereur [:o0ignition0o]]

Hey Georg, I would love to !

Comment 5

[Georg Fritzsche [:gfritzsche]]

Attachment: global_search.png

Cheers!
Here is an example of what i mean.
I searched for one term and get results from different categories/sections.
Because there are no separate headings, i can't tell which sections the results are actually from.

Comment 6

[Jeremy Lempereur [:o0ignition0o]]

Attachment: Bug 1395091 - about:telemetry global search should have headings before section results.

Put a table heading to each search section in the about:telemetry homepage.

Review commit: https://reviewboard.mozilla.org/r/209990/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209990/

Comment 7

[Jeremy Lempereur [:o0ignition0o]]

http://ibb.co/iSyLKw I've put each section into an h1 tag, since I'm not a really great UI designer ^^'
I hope I've covered every corner case, if I haven't please let me know and I'll follow up on this :)

Comment 8

[Georg Fritzsche [:gfritzsche]]

This looks more clear, cheers!
I'll redirect the review to Chris here.

Comment 9

[Jeremy Lempereur [:o0ignition0o]]

Great thanks a lot ! If there's an other task you would like me to handle, please tell me. I'm trying to ramp up my js / c++ skills :)

Comment 10

[Chris H-C :chutten]

Comment on attachment 8939689 [details]
Bug 1395091 - about:telemetry global search should have headings before section results.

https://reviewboard.mozilla.org/r/209990/#review215940

Nice use of modern language features and APIs.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/862df5b1a0c9
about:telemetry global search should have headings before section results. r=chutten

Comment 12

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/862df5b1a0c9

Comment 13

[Gerry Chang [:gchang]]

It's too late for 58, mark 58 won't fix.