1395131 - -Werror,-Wenum-compare-switch in IsXMMReversedOperands

Status: RESOLVED DUPLICATE of bug 1390214

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Sylvestre Ledru [:Sylvestre]]

clang trunk is complaining about the following declaration https://dxr.mozilla.org/mozilla-central/source/js/src/jit/x86-shared/Encoding-x86-shared.h?q=case+OP3_PEXTRD_EdVdqIb%3A&redirect_type=single#318

with:
/home/sylvestre/dev/mozilla/mozilla-central.hg/js/src/jit/x86-shared/Encoding-x86-shared.h:318:12: error: comparison of two values with different enumeration types in switch statement ('js::jit::X86Encoding::TwoByteOpcodeID' and 'js::jit::X86Encoding::ThreeByteOpcodeID') [-Werror,-Wenum-compare-switch]
 0:05.32       case OP3_PEXTRD_EdVdqIb:

Don't think it is a big deal, maybe we just want to ignore this warning on this file.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Dan, what do you think?