1395168 - Add a tests for key synthesis

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, enhancement)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Add tests for when we synthesize key events, including a test for bug 1387889.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Add tests for key synthesis (v1)

Add tests for synthesizing keys, including test for dummy keys and test
for wrong metastate for synthesized non-English keys (i.e. bug 1387889).

Comment 2

[Eugen Sawin [:esawin]]

Comment on attachment 8902705 [details] [diff] [review]
Add tests for key synthesis (v1)

Review of attachment 8902705 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/tests/browser/robocop/robocop_input.html
@@ +82,5 @@
> +          case "keydown":
> +          case "keypress":
> +          case "keyup":
> +            key_log += event.type + ":" + event.key + "," +
> +                       get_key_metastate(event) + ";";

Template-strings might be nice for this.

@@ +85,5 @@
> +            key_log += event.type + ":" + event.key + "," +
> +                       get_key_metastate(event) + ";";
> +            break;
> +          default:
> +            key_log += "unknown;"

Missing ;.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0066ef926e1
Add tests for key synthesis; r=esawin

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b0066ef926e1