Add a tests for key synthesis

RESOLVED FIXED in Firefox 57

Status

()

Firefox for Android
Keyboards and IME
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

unspecified
Firefox 57
All
Android
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
Add tests for when we synthesize key events, including a test for bug 1387889.
(Assignee)

Comment 1

9 months ago
Created attachment 8902705 [details] [diff] [review]
Add tests for key synthesis (v1)

Add tests for synthesizing keys, including test for dummy keys and test
for wrong metastate for synthesized non-English keys (i.e. bug 1387889).
Attachment #8902705 - Flags: review?(esawin)

Comment 2

9 months ago
Comment on attachment 8902705 [details] [diff] [review]
Add tests for key synthesis (v1)

Review of attachment 8902705 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/tests/browser/robocop/robocop_input.html
@@ +82,5 @@
> +          case "keydown":
> +          case "keypress":
> +          case "keyup":
> +            key_log += event.type + ":" + event.key + "," +
> +                       get_key_metastate(event) + ";";

Template-strings might be nice for this.

@@ +85,5 @@
> +            key_log += event.type + ":" + event.key + "," +
> +                       get_key_metastate(event) + ";";
> +            break;
> +          default:
> +            key_log += "unknown;"

Missing ;.
Attachment #8902705 - Flags: review?(esawin) → review+

Comment 3

9 months ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0066ef926e1
Add tests for key synthesis; r=esawin
https://hg.mozilla.org/mozilla-central/rev/b0066ef926e1
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.