Unable to delete from history if a top site is pinned

VERIFIED FIXED in Firefox 57

Status

()

Firefox
Activity Streams: Newtab
VERIFIED FIXED
3 months ago
2 months ago

People

(Reporter: ursula, Assigned: ursula)

Tracking

(Blocks: 1 bug)

57 Branch
Firefox 57
Points:
---

Firefox Tracking Flags

(firefox57 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
In NewtabUtils.jsm when we call deleteHistoryEntry we should also call PinnedLink.unpin to unpin the link first. Or else we can't actually delete the link, since it'll still be pinned and still be hanging around. Since we favour pinned links to show on AS, we'll still show it even though it's been deleted from history.

It should follow the same behaviour as a blocked links.
(Assignee)

Updated

3 months ago
Assignee: nobody → usarracini

Updated

3 months ago
Comment hidden (mozreview-request)

Comment 2

3 months ago
mozreview-review
Comment on attachment 8902774 [details]
Bug 1395203 - Unable to delete from history if a top site is pinned

https://reviewboard.mozilla.org/r/174438/#review179628

Looks good. Nice that PinnedLinks.unpin happily short circuits if it's not actually pinned.
Attachment #8902774 - Flags: review?(edilee) → review+

Comment 3

3 months ago
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e96f86e8071a
Unable to delete from history if a top site is pinned r=Mardak
https://hg.mozilla.org/mozilla-central/rev/e96f86e8071a
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57

Updated

3 months ago
Blocks: 1394533
I have reproduced this bug with Nightly 57.0a1 (2017-08-30) in Windows 10 (64-bit).

This bug's fix is verified with latest Nightly 57.0a1 (64-bit).

Build ID   :   20170906100107
User Agent :   Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

[bugday 20170906]

Comment 6

2 months ago
Pinned Top sites can be successfully deleted using the "(...)"context menu. Verified as fixed using latest Nightly 57.0a1 Build ID 20170918220054, on Windows 10 x64, Mac 10.12 and Ubuntu 14.04 x64.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
You need to log in before you can comment on or make changes to this bug.