Closed Bug 1395262 Opened 5 years ago Closed 5 years ago

replace e => console.error(e) with console.error

Categories

(DevTools :: Framework, enhancement)

enhancement
Not set
normal

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

Details

Attachments

(1 file)

We decided to do the reverse of bug 1234620: replace
e => console.error(e) with plain console.error.

Normally this wouldn't be worth doing, but a quick inspection showed
some invalid code like  .catch(e => console.error), which isn't useful at all.
Also, it's trivial to fix the normal uses of this pattern.
Comment on attachment 8902798 [details]
Bug 1395262 - use plain console.error in devtools promise catches;

https://reviewboard.mozilla.org/r/174468/#review179634

Thank you! Worth a try push before landing, but this is nice
Attachment #8902798 - Flags: review?(bgrinstead) → review+
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/18d3376156f0
use plain console.error in devtools promise catches; r=bgrins
https://hg.mozilla.org/mozilla-central/rev/18d3376156f0
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Depends on: 1396071
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.