replace e => console.error(e) with console.error

RESOLVED FIXED in Firefox 57

Status

RESOLVED FIXED
a year ago
6 months ago

People

(Reporter: tromey, Assigned: tromey)

Tracking

unspecified
Firefox 57

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
We decided to do the reverse of bug 1234620: replace
e => console.error(e) with plain console.error.

Normally this wouldn't be worth doing, but a quick inspection showed
some invalid code like  .catch(e => console.error), which isn't useful at all.
Also, it's trivial to fix the normal uses of this pattern.
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8902798 [details]
Bug 1395262 - use plain console.error in devtools promise catches;

https://reviewboard.mozilla.org/r/174468/#review179634

Thank you! Worth a try push before landing, but this is nice
Attachment #8902798 - Flags: review?(bgrinstead) → review+

Comment 3

a year ago
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/18d3376156f0
use plain console.error in devtools promise catches; r=bgrins

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/18d3376156f0
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Depends on: 1396071

Updated

6 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.