139528 - xml attachment that is actually binary gets corrupted

Status: RESOLVED WORKSFORME

(MailNews Core :: MIME, defect)

Description

[bob]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.9) Gecko/20020311
BuildID:    0.9.9

I attach a *.xml file and it has binary data in it(encrypted) and when the file
is saved at the receiving end of the email the file is corrupted .

Reproducible: Always
Steps to Reproduce:
1. make file with xml suffix and put any character data in it
2. encrypt file. I used gvim
3. send file to yourself
4. open attachment and save as
5. Try to decrypt and it ia garbage

Actual Results:  bad file

Expected Results:  good file

Comment 1

[bob]

Attachment: encrypted xml file

Comment 2

[bob]

Attachment: encrypted xml file in zip file

the password for encryption in gvim is 123

Comment 3

[bob]

Attachment: original xml file

Comment 4

[Boris Zbarsky [:bzbarsky]]

Wait.  You're sending the _encrypted_ file with a .xml extension?  That makes us
treat it as text/xml, we set that type on the mail, and then mailers do things
like newline conversions and the like on it...  so it would get corrupted, yes.

Comment 5

[Jean-Francois Ducarroz]

I am kind of confused by step 4:open attachment and save as

Are you opening the attachment into a browser window and then saving from there?
if it's the case, it possible that linefeed characters get changed. To avoid
that problem, you need to select the attachment in the message display window
(mail3Pane or standalone display window) and do the save attachment from there.

Comment 6

[bob]

Attachment: comments

Comment 7

[bob]

bzbarsky:

Is there a way to tell mozilla to treat an attachment a certain way irrespective
of its suffix??

ducarroz:

I attach the file and then when I receive it from myself I right click on the
attachment(xml doesnt allow save as directly) and use save as.
It could have something to do with the fact that certain attachments are shown
in the contents window. xml, jpg, etc. The xml when it gets shown in the content
window gets screwed up? BTW is there a way to turn this "feature" off. In other
words all attachments should stay as attachments until I make a request to open
them.

bob

Comment 8

[Jean-Francois Ducarroz]

We don't have yet the feature to not show attachment inline like we do in 4.x.
Bob, when you save the attachment from the message display, did it get
corrupted? I tried myself using your test case and I did not see any problem (I
compared the sent file with the received one, they are identical)

Comment 9

[bob]

I never tried saving from the message display I always saved from the attachment
box by right clicking and selecting save as. I also tried it from the sent
folder and it was corrupted.

Comment 10

[bob]

I just did a hex dump and diff with gvim and it shows the changes that corrupted
the file. Basically as soon as it encountered a 0x0a mozilla inserted a 0x0d
before it. 

bob

Comment 11

[Boris Zbarsky [:bzbarsky]]

Reiterating what I said in email:

The file has a .xml extension. That means we detect it as being of type
text/xml.  Now text/xml is a text type.  So I suspect when we send the mail we
do newline conversion to network CR/LF newlines (from Unix LF newlines).  If the
mail is now received on Windows, the CR/LF newlines are kept (since that's the
native Windows newline format).

Comment 12

[bob]

I agree as to the cause of this "problem". The newlines are being expanded. But
I would like to point out what the expectation is, if I attach a file I am
expecting that mozilla will do a bit for bit transfer of the file. I dont want
mozilla to do anything to the file except transfer it. If I didn't want bit for
bit transfer than I could have included it in the body of the message. Another
compelling reason to fix it is that I believe outlook express and other mailers
do a bit for bit transfer. I have not verified this.

bob

Comment 13

[Bharat]

Reporter, do you still see this problem in the latest nightly (or even 1.5)? If
not, this bug can be closed. Thanks.

Comment 14

[Aaron Lawrence]

Works for me, Moz 1.8a3 20040716.
The file is identical when I get it back and detach from the attachments list.