1395286 - Moving resources (e.g. to content-accessible) causes packaging failures (at least for Android) without a clobber

Status: RESOLVED DUPLICATE of bug 1500924

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Jan Henning [:JanH]]

The first error message I get is
> 0:01.48 IOError: [Errno 2] No such file or directory: '../../../dist/bin/chrome/en-US/locale/en-US/browser/handling.properties'
> 0:01.53 /home/jan/Mozilla/mozilla-central/toolkit/mozapps/installer/packager.mk:36: recipe for target 'stage-package' failed

and if I backout bug 1255404, packaging then fails with
> ERROR: The following duplicated files are not allowed:
> 0:24.79 chrome/toolkit/res/viewsource.css
> 0:24.79 contentaccessible/viewsource.css

As far I can see, we're missing a clobber here.

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1395286 - Clobber to fix packaging failure on Android.

Review commit: https://reviewboard.mozilla.org/r/174550/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174550/

Comment 2

[Jan Henning [:JanH]]

Comment on attachment 8902855 [details]
Bug 1395286 - Clobber to fix packaging failure on Android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/174550/diff/1-2/

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8902855 [details]
Bug 1395286 - Clobber to fix packaging failure on Android.

https://reviewboard.mozilla.org/r/174550/#review179832

Usually for a clobber commit, you mention the original bug in the commit message (e.g. [1]). And then you file a bug about the need to clobber; the goal of that bug is to make us not require a clobber for similar cases in the future. In this case, I suggest you keep this bug open as the fix-clobber bug, and land this CLOBBER commit with the original bug number (e.g. bug 1255404).

[1] https://hg.mozilla.org/mozilla-central/rev/278c3bf8f7f4

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71ee70900245
Clobber to fix packaging failure on Android. r=jchen

Comment 5

[Jan Henning [:JanH]]

(In reply to Jim Chen [:jchen] [:darchons] from comment #3)
> In this case, I suggest you keep this bug open as the
> fix-clobber bug, and land this CLOBBER commit with the original bug number
> (e.g. bug 1255404).

Sorry for not fully following this, but I didn't want to delay this until I can access my development machine again.

I probably won't be looking into this further, but hazarding a guess regarding bug 863246, the files presumably get copied into the object directory at some stage and we only copy the current set of files, but don't delete any outdated files that are no longer necessary. I wonder why that didn't cause any problems for Desktop builds, though - is it just because people are less likely to package Desktop builds as it's not necessary for running the build, whereas for Android packaging is mandatory for obtaining a useable APK? Or is the Desktop packaging immune to those kinds of duplicated files?

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/71ee70900245

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:nalexander, maybe it's time to close this bug?

Comment 8

[Nick Alexander :nalexander [he/him]]

Let's close this as a dupe of Bug 1500924.