Closed
Bug 1395305
Opened 7 years ago
Closed 7 years ago
Turn Activity Stream off for tests in browser/components/migration/tests/browser/
Categories
(Firefox :: New Tab Page, enhancement)
Tracking
()
RESOLVED
FIXED
Firefox 57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: ursula, Assigned: ursula)
References
Details
Attachments
(1 file)
These tests are irrelevant for activity stream, let's disable activity stream for those tests. If I'm not mistaken, the auto-migration is off now anyways, right Gijs?
Flags: needinfo?(gijskruitbosch+bugs)
|
||
Comment 1•7 years ago
|
||
If we can just turn off activity stream for these, we'll use the fancy new [DEFAULT] prefs= from bug 1328830! ;)
Depends on: 1328830
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → usarracini
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
(In reply to Ed Lee :Mardak from comment #1) > If we can just turn off activity stream for these, we'll use the fancy new > [DEFAULT] prefs= from bug 1328830! ;) We'll need to keep in mind that that won't work if we need to uplift AS stuff to 56 (which I don't know if we do...) (In reply to Ursula Sarracini (:ursula) from comment #0) > These tests are irrelevant for activity stream, let's disable activity > stream for those tests. If I'm not mistaken, the auto-migration is off now > anyways, right Gijs? FWIW, there's still talk about the automigration stuff - I'm in a meeting about our last trial runs on release on Thursday next week - so in general, we may need to be revisiting this in the future. Anyway, this is fine for now.
Flags: needinfo?(gijskruitbosch+bugs)
|
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8902872 [details] Bug 1395305 - Turn Activity Stream off for tests in browser/components/migration/tests/browser/ https://reviewboard.mozilla.org/r/174564/#review180420
Attachment #8902872 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by usarracini@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c6f942bf16a8 Turn Activity Stream off for tests in browser/components/migration/tests/browser/ r=Gijs
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c6f942bf16a8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•