Closed
Bug 1395359
Opened 7 years ago
Closed 7 years ago
Crash in mozilla::dom::HTMLMediaElement::WakeLockBoolWrapper::UpdateWakeLock
Categories
(Core :: Audio/Video: Playback, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | unaffected |
firefox57 | --- | fixed |
People
(Reporter: marcia, Assigned: alwu)
Details
(Keywords: crash, regression)
Crash Data
Attachments
(1 file)
This bug was filed from the Socorro interface and is report bp-bb82d739-202d-45ec-932b-e06360170830. ============================================================= Seen while looking at crash stats - crashes started using 20170830100230: http://bit.ly/2eGzr1d Code was touched in Bug 1373888. ni on alwu
Flags: needinfo?(alwu)
Reporter | ||
Comment 1•7 years ago
|
||
[@ mozilla::dom::HTMLMediaElement::SetVolumeInternal] which is a Mac signature looks related.
Crash Signature: [@ mozilla::dom::HTMLMediaElement::WakeLockBoolWrapper::UpdateWakeLock] → [@ mozilla::dom::HTMLMediaElement::WakeLockBoolWrapper::UpdateWakeLock]
[@ mozilla::dom::HTMLMediaElement::SetVolumeInternal]
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → alwu
Flags: needinfo?(alwu)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8903018 -
Flags: review?(cpearce)
Updated•7 years ago
|
Priority: -- → P1
Assignee | ||
Comment 4•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2aaf2b34d76bce634117b7b6d466d074094c0a76
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8903018 [details] Bug 1395359 - make sure all references value are set before we use them. https://reviewboard.mozilla.org/r/174788/#review180792 ::: dom/html/HTMLMediaElement.h:821 (Diff revision 1) > > void SetDecoder(MediaDecoder* aDecoder); > > class WakeLockBoolWrapper { > public: > - explicit WakeLockBoolWrapper(bool val = false) > + explicit WakeLockBoolWrapper(bool aVal, HTMLMediaElement* aOuter) You could make mOuter a reference, then it can't be null.
Attachment #8903018 -
Flags: review?(cpearce) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f3f4460f12361f92208b11f1945c58bfac2dc9f
Assignee | ||
Comment 8•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3361d6af47129b0dc77e72001e35d31423af0d86
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1518f8954ba2 make sure all references value are set before we use them. r=cpearce
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1518f8954ba2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•7 years ago
|
status-firefox55:
--- → unaffected
status-firefox56:
--- → unaffected
status-firefox-esr52:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•