Closed Bug 1395359 Opened 7 years ago Closed 7 years ago

Crash in mozilla::dom::HTMLMediaElement::WakeLockBoolWrapper::UpdateWakeLock

Categories

(Core :: Audio/Video: Playback, defect, P1)

Unspecified
Windows 10
defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- fixed

People

(Reporter: marcia, Assigned: alwu)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-bb82d739-202d-45ec-932b-e06360170830.
=============================================================

Seen while looking at crash stats - crashes started using 20170830100230: http://bit.ly/2eGzr1d

Code was touched in Bug 1373888. ni on alwu
Flags: needinfo?(alwu)
[@ mozilla::dom::HTMLMediaElement::SetVolumeInternal] which is a Mac signature looks related.
Crash Signature: [@ mozilla::dom::HTMLMediaElement::WakeLockBoolWrapper::UpdateWakeLock] → [@ mozilla::dom::HTMLMediaElement::WakeLockBoolWrapper::UpdateWakeLock] [@ mozilla::dom::HTMLMediaElement::SetVolumeInternal]
Assignee: nobody → alwu
Flags: needinfo?(alwu)
Attachment #8903018 - Flags: review?(cpearce)
Priority: -- → P1
Comment on attachment 8903018 [details]
Bug 1395359 - make sure all references value are set before we use them.

https://reviewboard.mozilla.org/r/174788/#review180792

::: dom/html/HTMLMediaElement.h:821
(Diff revision 1)
>  
>    void SetDecoder(MediaDecoder* aDecoder);
>  
>    class WakeLockBoolWrapper {
>    public:
> -    explicit WakeLockBoolWrapper(bool val = false)
> +    explicit WakeLockBoolWrapper(bool aVal, HTMLMediaElement* aOuter)

You could make mOuter a reference, then it can't be null.
Attachment #8903018 - Flags: review?(cpearce) → review+
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1518f8954ba2
make sure all references value are set before we use them. r=cpearce
https://hg.mozilla.org/mozilla-central/rev/1518f8954ba2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.