1395365 - Change URL bar resizing to be interoperable with Chrome and Safari

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Toolbar, defect, P5)

Description

[vschs007]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Safari/537.36

Steps to reproduce:

Visit bokand.github.io/demo/urlbarsize.html
Scroll down to hide the url bar



Actual results:

All four bars resize



Expected results:

The orange bars should not resiz

Comment 1

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Karl, is this also a bug affected by the Chrome behavior change just like bug 1064982?  I mean we can close this too?

Comment 3

[Karl Dubost💡 :karlcow]

Hiro,

It seems this is now working the same in both Firefox and Chrome.
I think we can close.

If you go to https://bokand.github.io/demo/urlbarsize.html
You will noticed just two small differences that might be worth investigating.

1. When scrolling up the two orange bars have different sizes in Chrome, same sizes in Firefox
2. There is a kind of jankiness when scrolling on Firefox when the two orange bars becomes suddenly longer (I guess when the URL bar is hidding).

Comment 4

[Hiroyuki Ikezoe (:hiro)]

(In reply to Karl Dubost💡 :karlcow from comment #3)
> Hiro,
> 
> It seems this is now working the same in both Firefox and Chrome.
> I think we can close.
> 
> If you go to https://bokand.github.io/demo/urlbarsize.html
> You will noticed just two small differences that might be worth
> investigating.
> 
> 1. When scrolling up the two orange bars have different sizes in Chrome,
> same sizes in Firefox

It seems Chrome does factor the bottom button area on Android OS (I don't know what the area is called) into viewport units.

> 2. There is a kind of jankiness when scrolling on Firefox when the two
> orange bars becomes suddenly longer (I guess when the URL bar is hidding).

I think that's because the window.innerHeight is expanded when the URL is hiding.  And I think it's reasonable.