Rename BaseTest so it indicates it's been replaced

RESOLVED FIXED in Firefox 58

Status

()

Firefox for Android
Testing
P3
normal
RESOLVED FIXED
9 months ago
7 months ago

People

(Reporter: mcomella, Assigned: mcomella)

Tracking

unspecified
Firefox 58
All
Android
Points:
---

Firefox Tracking Flags

(fennec+, firefox56 wontfix, firefox57 wontfix, firefox58 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

UITest is the replacement for BaseTest but it looks like new tests, like testActivityStreamContextMenu, are still being written. We should rename it, or deprecate it, so that it's obvious new tests shouldn't be written with it. From the UITest file header:

 * A base test class for Robocop (UI-centric) tests. This and the related classes attempt to
 * provide a framework to improve upon the issues discovered with the previous BaseTest
 * implementation by providing simple test authorship and framework extension, consistency,
 * and reliability.
 *
 * For documentation on writing tests and extending the framework, see
 * https://wiki.mozilla.org/Mobile/Fennec/Android/UITest
Priority: -- → P3

Comment 1

9 months ago
ni myself so I can remember to bring this up in eng mt.
tracking-fennec: ? → +
Flags: needinfo?(cnevinchen)

Comment 2

7 months ago
Hi Wesly, Joe. Please help put this in the sprint planing.
Flags: needinfo?(wehuang)
Flags: needinfo?(jcheng)
Flags: needinfo?(cnevinchen)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
If this turns out to be more complicated than I predicted, I might not have the time to work on it but here's the simple patch. I'll run a test run through try.
Assignee: nobody → michael.l.comella

Comment 6

7 months ago
mozreview-review
Comment on attachment 8921123 [details]
Bug 1395370: Add deprecation to BaseTest.

https://reviewboard.mozilla.org/r/192104/#review197468
Attachment #8921123 - Flags: review?(cnevinchen) → review+

Comment 7

7 months ago
mozreview-review
Comment on attachment 8921124 [details]
Bug 1395370: BaseTest -> OldBaseTest.

https://reviewboard.mozilla.org/r/192106/#review197470
Attachment #8921124 - Flags: review?(cnevinchen) → review+
Flags: needinfo?(wehuang)
Flags: needinfo?(jcheng)
https://hg.mozilla.org/mozilla-central/rev/a684fee00172
https://hg.mozilla.org/mozilla-central/rev/41053a4acfa1
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
status-firefox56: --- → wontfix
status-firefox57: --- → wontfix
You need to log in before you can comment on or make changes to this bug.