1395393 - Update libcubeb to revision 42404c88

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, enhancement, P1)

Description

[Matthew Gregan [:kinetik]]

This picks up the following changes:

a8460cb Update src/speex import to 85e8ad5432eb9333f727e7b18c97995317eabf02.
fcf854b Fix a gcc warning with -Wparentheses (#349)
8b17b0e cubeb: Intern string support.
2160942 pulse: Implement interning device ids.
221f72f wasapi: Implement interning device ids.
a9290a2 jack: Implement stable device ids.
608affc test_sanity: Assert devid are same between two cubeb_eumerate_devices.
52b467d cubeb: Remove cubeb_util_default_device_collection_destroy().
f1c72f4 Add doc comment.
c3edd7f audiounit: Fix buffer over-run in audiounit_enumerate_devices.
42404c8 Add a thread reset API for the ring buffer class.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: Update libcubeb to revision 42404c88.

Comment 2

[Matthew Gregan [:kinetik]]

There's also a PR against cubeb-rs to update the submodule there: https://github.com/djg/cubeb-rs/pull/14

Comment 3

[Matthew Gregan [:kinetik]]

Attachment: Update libcubeb to revision 6d5ba163. r?kamidphish

Comment 4

[Matthew Gregan [:kinetik]]

Note to self: delete media/libcubeb/src/cubeb_utils.c when landing this.

Comment 5

[Alex Chronopoulos [:achronop]]

Attachment: Part2: update cubeb to revision 2e5814d.

Updates this bug with one more commit:
2e5814d Paul Adenot     Allow passing in CUBEB_LAYOUT_UNDEFINED as layout for the output side in WASAPI.

This commit solves a high traffic crash on windows, described on Bug 1394873. I add it here to catch next Nightly. I will update the title of this bug if patch is accepted.

Comment 6

[Paul Adenot (:padenot)]

Attachment: Bug 1395393 - Update libcubeb to 2e5814de.

Review commit: https://reviewboard.mozilla.org/r/175416/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175416/

Comment 7

[Paul Adenot (:padenot)]

I want to land this before the weekend, it's super super super crashy at the moment, and it's the weekend for Matthew and Dan already.

I've called `hg add` and `hg rm` on the right files and made the `moz.build` changes, so I think it's ok.

Comment 8

[Alex Chronopoulos [:achronop]]

Comment on attachment 8903635 [details]
Bug 1395393 - Update libcubeb to 2e5814de.

https://reviewboard.mozilla.org/r/175416/#review180528

Looks good

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/05f7a8e50b2c
Update libcubeb to 2e5814de. r=achronop

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0cc4d42a9f6f
Fix bustage on a CLOSED TREE.

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/05f7a8e50b2c
https://hg.mozilla.org/mozilla-central/rev/0cc4d42a9f6f