Closed
Bug 1395396
Opened 7 years ago
Closed 7 years ago
Update Debugger frontend (8/30/2017).
Categories
(DevTools :: Debugger, enhancement, P3)
DevTools
Debugger
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
Details
Attachments
(1 file, 2 obsolete files)
607.63 KB,
patch
|
jdescottes
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8902948 -
Flags: review?(jdescottes)
Assignee | ||
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c57d8c074a29bb53c3132a10ce08c497dc3d827f
Updated•7 years ago
|
Assignee: nobody → jlaster
Status: NEW → ASSIGNED
Priority: -- → P3
Comment 3•7 years ago
|
||
Comment on attachment 8902948 [details] [diff] [review] 8-30.patch Review of attachment 8902948 [details] [diff] [review]: ----------------------------------------------------------------- - patch doesn't apply - project search is not working (either via cmd+shift+F, or cmd+P -> "Find in files" is disabled) ::: devtools/client/debugger/new/test/mochitest/examples/async.js @@ +1,1 @@ > +async function thing(inc) { note: all files in the examples folder are missing a license header.
Attachment #8902948 -
Flags: review?(jdescottes) → review-
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8903701 -
Flags: review?(jdescottes)
Comment 5•7 years ago
|
||
Comment on attachment 8903701 [details] [diff] [review] 8-30-2.patch Review of attachment 8903701 [details] [diff] [review]: ----------------------------------------------------------------- Some issues with the pref file. Other files look OK. Will need to test the bundle a bit later (but project search was fixed since the last bundle I tested) ::: devtools/client/preferences/debugger.js @@ +1,4 @@ > /* Any copyright is dedicated to the Public Domain. > * http://creativecommons.org/publicdomain/zero/1.0/ */ > > +#ifdef RELEASE_OR_BETA Remove this @@ +6,5 @@ > > // Enable the Debugger > pref("devtools.debugger.enabled", true); > pref("devtools.debugger.chrome-debugging-host", "localhost"); > +pref("devtools.debugger.chrome-debugging-port", 6080); This pref was removed in Bug 1392744
Assignee | ||
Comment 6•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=62b0af5d3b9c9549c75acaf565d7d33596f12b1d
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #8902948 -
Attachment is obsolete: true
Attachment #8903701 -
Attachment is obsolete: true
Attachment #8903701 -
Flags: review?(jdescottes)
Attachment #8903759 -
Flags: review?(jdescottes)
Assignee | ||
Comment 8•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=51b3bb7071254aac218411173a6866f76145cd26
Assignee | ||
Comment 9•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd5950d79584a7bbf8680712a876802609dfd8b9
Comment 10•7 years ago
|
||
Comment on attachment 8903759 [details] [diff] [review] 8-30-3.patch Review of attachment 8903759 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks Jason! Regarding project search I feel like the UX still needs some polish: - I have to type enter for the search to start but this is not mentioned anywhere (so initially I was just typing my query and waiting) - there is no loading indicator to show to the user that the query is in progress I am mentioning this because we won't have a lot of time to drop additional bundles for 57, so maybe a small polish session for this feature would be nice to have.
Attachment #8903759 -
Flags: review?(jdescottes) → review+
Comment 11•7 years ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/367e87978050 Update Debugger frontend (8/30/2017). r=jdescottes
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/367e87978050
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 13•7 years ago
|
||
Screenshots: https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=59db725def8282e1d77e83f002d247c7d0f95237&newProject=mozilla-central&newRev=37824bf5c5b08afa7e689fceb935b8f457ebd9eb&filter=devtools
Comment 14•7 years ago
|
||
Johann: thanks for the heads up. The UI differences are expected and correct. I never remember, do we have anything to do to validate the new screenshots as the correct "baseline"?
Flags: needinfo?(jhofmann)
Comment 15•7 years ago
|
||
(In reply to Julian Descottes [:jdescottes] from comment #14) > Johann: thanks for the heads up. The UI differences are expected and > correct. I never remember, do we have anything to do to validate the new > screenshots as the correct "baseline"? Nope, it just takes the previous screenshot set as baseline. If we don't act on the reported differences, they become the new baseline automatically. :) Generally I don't require a reaction from patch authors if everything looks as expected. FWIW, if a diffset contains changes that look strange to me, I will comment that in the bug as well (or open a follow-up bug if it's really obvious).
Flags: needinfo?(jhofmann)
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•