1395406 - Crash when using two USB tokens on U2F test site

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect, P1)

Description

[Matt Wobensmith [:mwobensmith][:matt:]]

With latest test build from 30-08-2017:

1. Visit https://demo.yubico.com/u2f
2. Insert two USB keys
3. Follow instructions to create account
4. Log in and touch token on prompt
** Note that token displays steady light instead of blinking light
5. Wait a few seconds
6. Attempt to interact with browser by refreshing page, etc.
** Note that browser is non-responsive.
7. Remove USB token that you interacted with and wait a few seconds, then reinsert.

Result: 
Crash


Note that between steps 6 and 7, you may experience a crash at intermittent times, as the previous steps appear to make Firefox unstable. I have attempted to find a case that crashes consistently.

Also note that test sites using WebAuthN and multiple tokens don't appear to have this problem.

Comment 1

[Matt Wobensmith [:mwobensmith][:matt:]]

Attachment: log1.txt

Comment 2

[Matt Wobensmith [:mwobensmith][:matt:]]

Attachment: log2.txt

Comment 3

[J.C. Jones [:jcj] (he/they)]

Thanks, Matt! From the logs, this is probably crashing during the Cancel operation, which is not too surprising. In Bug 1245527 (which this test build uses), the U2FManager.cpp implementation is very, very close to the WebAuthn implementation -- however WebAuthn uses JS Promises, whereas U2F uses callbacks, and the state interactions with cancellation are a little different.

It'd make sense that we would have to treat them differently in the code.

Comment 4

[J.C. Jones [:jcj] (he/they)]

I believe this may have been fixed in https://bugzilla.mozilla.org/show_bug.cgi?id=1245527#c22 ; I can no longer reproduce it locally, anyway.

When Bug 1245527 lands, I'll produce a new set of builds and we can try it again.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

I think we can call this fixed, I can't reproduce it with Nightly. Matt? :)

Comment 6

[Matt Wobensmith [:mwobensmith][:matt:]]

Appears to be fixed, thanks Tim.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Cool, thanks Matt!