Closed Bug 1395417 Opened 2 years ago Closed 2 years ago

Expose eglCreateDeviceANGLE and eglReleaseDeviceANGLE in GLLibraryEGL

Categories

(Core :: Graphics, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(2 files, 1 obsolete file)

eglCreateDeviceANGLE and eglReleaseDeviceANGLE needs to be exposed for Bug 1395107.
Blocks: 1395107
Assignee: nobody → sotaro.ikeda.g
Attachment #8902988 - Flags: review?(jgilbert)
Comment on attachment 8902988 [details] [diff] [review]
patch - Expose eglCreateDeviceANGLE and eglReleaseDeviceANGLE

Review of attachment 8902988 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLLibraryEGL.h
@@ +491,5 @@
>                                                                   void* texture,
>                                                                   const EGLAttrib* attrib_list);
> +        // ANGLE_device_creation
> +        EGLDeviceEXT (GLAPIENTRY * fCreateDeviceANGLE) (EGLint device_type,
> +                                                        void *native_device,

Star against type, here and elsewhere.
Attachment #8902988 - Flags: review?(jgilbert) → review+
(In reply to Jeff Gilbert [:jgilbert] from comment #2)
> Comment on attachment 8902988 [details] [diff] [review]
> patch - Expose eglCreateDeviceANGLE and eglReleaseDeviceANGLE
> 
> Review of attachment 8902988 [details] [diff] [review]:
> -----------------------------------------------------------------
> > +        // ANGLE_device_creation
> > +        EGLDeviceEXT (GLAPIENTRY * fCreateDeviceANGLE) (EGLint device_type,
> > +                                                        void *native_device,
> 
> Star against type, here and elsewhere.

Thanks! I am going to update it.
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9dedf8ea07cd
Expose eglCreateDeviceANGLE and eglReleaseDeviceANGLE r=jgilbert
There was fallouts of applying the comment. Very trivial fix.
Attachment #8903037 - Attachment is obsolete: true
Attachment #8903037 - Attachment is obsolete: false
Attachment #8903044 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/9dedf8ea07cd
https://hg.mozilla.org/mozilla-central/rev/7584d9067b54
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.