Closed Bug 1395431 Opened 7 years ago Closed 7 years ago

Remove ChannelMediaResource::mDataReceivedEvent

Categories

(Core :: Audio/Video: Playback, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

http://searchfox.org/mozilla-central/rev/51b3d67a5ec1758bd2fe7d7b6e75ad6b6b5da223/dom/media/MediaResource.cpp#869,880

When OMT data delivery is enabled, CacheClientNotifyDataReceived() and DoNotifyDataReceived() will run on different threads. It is a data race to access mDataReceivedEvent without synchronization.

We want to remove mDataReceivedEvent to avoid the data race.
Assignee: nobody → jwwang
Blocks: 1382978
Priority: -- → P1
Attachment #8903014 - Flags: review?(cpearce)
Comment on attachment 8903014 [details]
Bug 1395431 - dispatch a task to call MediaResourceCallback::NotifyDataArrived() in CacheClientNotifyDataReceived().

https://reviewboard.mozilla.org/r/174784/#review180788
Attachment #8903014 - Flags: review?(cpearce) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/670f548e6689
dispatch a task to call MediaResourceCallback::NotifyDataArrived() in CacheClientNotifyDataReceived(). r=cpearce
https://hg.mozilla.org/mozilla-central/rev/670f548e6689
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Blocks: 1428688
No longer blocks: 1428688
You need to log in before you can comment on or make changes to this bug.