Block inlining in JIT backtracking allocator in Nightly

RESOLVED FIXED in Firefox 57

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
This should help us get better stacks from crash-stats and also make debugging easier in Nightly.  Perf impact on speedometer appears minimal (over 9-13 runs, avg difference locally is 105.99 vs 105.52, way less than the run-to-run variance).  Even so, restricting this to Nightly for now; we could make it EARLY_BETA_OR_EARLIER if we wanted.
(Assignee)

Comment 1

2 months ago
Created attachment 8903013 [details] [diff] [review]
Block some inlining for better debugging (in Nightly)
(Assignee)

Comment 2

2 months ago
Comment on attachment 8903013 [details] [diff] [review]
Block some inlining for better debugging (in Nightly)

r=luke
Attachment #8903013 - Flags: review+

Comment 3

2 months ago
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f9ee3fd59f9
Block some inlining for better debugging (in Nightly) r=luke
https://hg.mozilla.org/mozilla-central/rev/6f9ee3fd59f9
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.