Closed Bug 1395452 Opened 7 years ago Closed 7 years ago

Don't call GetAnimationController without calling HasAnimationController first

Categories

(Core :: SVG, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: birtles, Assigned: birtles)

References

Details

Attachments

(1 file)

GetAnimationController() will lazily create an animation controller so unless we need one, we should call HasAnimationController first.

There are a few places in the code base where we call GetAnimationController without first calling HasAnimationController first. Some of them are ok, some of them I'm not sure about, but a couple of them I'm fairly sure should call HasAnimationController first. In this bug I'd like to fix just those two call sites that appear to be wrong.
Comment on attachment 8903039 [details]
Bug 1395452 - Call HasAnimationController() before GetAnimationController();

https://reviewboard.mozilla.org/r/174812/#review179870
Attachment #8903039 - Flags: review?(hikezoe) → review+
This might be better (apparently android-api-15 isn't recognized any more):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=795bc59df3249b06b16feef1f9e270c5d8203557
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6950531b043
Call HasAnimationController() before GetAnimationController(); r=hiro
https://hg.mozilla.org/mozilla-central/rev/c6950531b043
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Blocks: 1389317
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: