Closed
Bug 1395454
Opened 9 years ago
Closed 8 years ago
Remove repeated addMock step
Categories
(SeaMonkey :: Release Engineering, enhancement)
SeaMonkey
Release Engineering
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ewong, Assigned: bhavesh1999)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
|
641 bytes,
patch
|
ewong
:
review+
|
Details | Diff | Splinter Review |
Apparently I had added addMockSteps() twice.
First instance:
https://hg.mozilla.org/build/buildbotcustom/file/1d60e4f2efa8/process/factory.py#l605
Second instance:
https://hg.mozilla.org/build/buildbotcustom/file/1d60e4f2efa8/process/factory.py#l1029
We don't need the 2nd one as the first one is already provided during
MozillaBuildFactory's __init__ sequence.
| Reporter | ||
Updated•9 years ago
|
Keywords: good-first-bug
| Reporter | ||
Updated•9 years ago
|
Summary: Remove repeated addMock steps → Remove repeated addMock step
I would like to work on this as my first contribution. Can you please guide me where can I edit this file and where I can submit the changes?
| Reporter | ||
Comment 2•8 years ago
|
||
(In reply to Bhavesh from comment #1)
> I would like to work on this as my first contribution. Can you please guide
> me where can I edit this file and where I can submit the changes?
Hi Bhavesh,
First, clone https://hg.mozilla.org/SeaMonkey/buildbotcustom.
Then, you go edit process/factory.py and remove the redundant addMockSteps() call.
Hi,
I cloned the repo. I did not find addMockSteps() function in the file. I think it has been removed/renamed/modified. Please could you verify if this is the case.
Flags: needinfo?(ewong)
| Reporter | ||
Comment 4•8 years ago
|
||
(In reply to Bhavesh from comment #3)
> Hi,
> I cloned the repo. I did not find addMockSteps() function in the file. I
> think it has been removed/renamed/modified. Please could you verify if this
> is the case.
It's here:
https://hg.mozilla.org/SeaMonkey/buildbotcustom/file/tip/process/factory.py#l1206
You can also get rid of the condition the line before that.
Flags: needinfo?(ewong)
I am really sorry for the delay, I was looking under the default branch by mistake.
Updated•8 years ago
|
Assignee: nobody → bhavesh1999
Status: NEW → ASSIGNED
Comment 7•8 years ago
|
||
Comment on attachment 8985116 [details] [diff] [review]
bug1395454patch
Bhavesh if you attach a patch best to ask either for feedback or review. Might get lost otherwise. I did set r? for you and assigned the bug to you.
Attachment #8985116 -
Flags: review?(ewong)
Comment 9•8 years ago
|
||
Nothing to be sorry about. All good. I just sometimes found patches which were a few weeks or even months old and were overlooked becuase nothing was set.
Comment 10•8 years ago
|
||
Oh one more item. The patch is missing a comment:
> # Parent c453a7282d2057cedc381e12f1449a4faf2316ba
> [mq]: patch
You usally want to add one like Bug 1395454 - Remove duplicate mock step.
Look at hg qnew for patch generation. It asks for a comment.
| Assignee | ||
Comment 11•8 years ago
|
||
(In reply to Frank-Rainer Grahl (:frg) from comment #10)
> Oh one more item. The patch is missing a comment:
>
> > # Parent c453a7282d2057cedc381e12f1449a4faf2316ba
> > [mq]: patch
>
> You usally want to add one like Bug 1395454 - Remove duplicate mock step.
>
> Look at hg qnew for patch generation. It asks for a comment.
I was searching for adding a comment but hg qnew did not ask for a comment and I was wondering why. Is there a way to add comment explicitly or is there an extended command like hg qnew -c or anything like that?
Flags: needinfo?(frgrahl)
Comment 12•8 years ago
|
||
hg qrefresh -m "new commit message"
Maybe you have not set the editor correctly. If you use TortoiseHg it will also not prompt. I need to do it from the command line in this case or just edit the patch directly :)
Flags: needinfo?(frgrahl)
| Reporter | ||
Comment 13•8 years ago
|
||
Comment on attachment 8985116 [details] [diff] [review]
bug1395454patch
Review of attachment 8985116 [details] [diff] [review]:
-----------------------------------------------------------------
looks good!
Attachment #8985116 -
Flags: review?(ewong) → review+
| Assignee | ||
Comment 14•8 years ago
|
||
Thanks a lot for helping me out Frank and Edmund!
Comment 15•8 years ago
|
||
https://hg.mozilla.org/build/buildbotcustom/rev/947694c4b4906bce66c1435be27ec3fe294ea9e4
Thanks Bhavesh
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
| Reporter | ||
Comment 16•8 years ago
|
||
(In reply to Frank-Rainer Grahl (:frg) from comment #15)
> https://hg.mozilla.org/build/buildbotcustom/rev/
> 947694c4b4906bce66c1435be27ec3fe294ea9e4
>
> Thanks Bhavesh
Thanks again for the patch. Transplanted it to SeaMonkey/buildbotcustom.
You need to log in
before you can comment on or make changes to this bug.
Description
•