Closed Bug 1395468 Opened 7 years ago Closed 7 years ago

[EME] Remove WidevineAdapter and its related code.

Categories

(Core :: Audio/Video: GMP, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: JamesCheng, Assigned: JamesCheng)

References

Details

Attachments

(3 files)

A prerequisite bug for removing PGMPDecryptor.
We now only use the Chromium CDM interface,
1. Remove media.eme.chromium-api.enabled preference and its related code.
2. We remove the instantiation of EMEVideoDecoder and GMPCDMProxy in step 1. Just delete it and its h/cpp from moz.build. 
3. Remove WidevineAdapter and its related classes.
Fix the review feedback from bug 1392506.

Thanks.
Attachment #8903057 - Flags: review?(cpearce)
Attachment #8903058 - Flags: review?(cpearce)
Attachment #8903059 - Flags: review?(cpearce)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5db6c161a7f51d3eb932fe168cc05087b712c16a

Hope the change can pass Gtest
Whiteboard: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5db6c161a7f51d3eb932fe168cc05087b712c16a
Rank: 21
Priority: -- → P2
Whiteboard: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5db6c161a7f51d3eb932fe168cc05087b712c16a
Comment on attachment 8903057 [details]
Bug 1395468 - [Part1] Remove media.eme.chromium-api.enabled preference and its related code.

https://reviewboard.mozilla.org/r/174832/#review180796
Attachment #8903057 - Flags: review?(cpearce) → review+
Comment on attachment 8903058 [details]
Bug 1395468 - [Part2] Remove the EMEVideoDecoder and GMPCDMProxy related files.

https://reviewboard.mozilla.org/r/174834/#review180808
Attachment #8903058 - Flags: review?(cpearce) → review+
Comment on attachment 8903059 [details]
Bug 1395468 - [Part3] Remove WidevineAdapter and its related classes.

https://reviewboard.mozilla.org/r/174836/#review180812
Attachment #8903059 - Flags: review?(cpearce) → review+
Pushed by jacheng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0dc9ff0ccee0
[Part1] Remove media.eme.chromium-api.enabled preference and its related code. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/77cea4798bf5
[Part2] Remove the EMEVideoDecoder and GMPCDMProxy related files. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/212dce0bc8b8
[Part3] Remove WidevineAdapter and its related classes. r=cpearce
Blocks: 1396493
You need to log in before you can comment on or make changes to this bug.