Closed Bug 1395512 Opened 7 years ago Closed 7 years ago

Make dom/svg/test/test_text_2.html produce useful and non-inverted error messages

Categories

(Core :: SVG, defect)

Product:
Core
Component:
SVG
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

patch
2.38 KB, patch
jfkthame
: review+
Details | Diff | Splinter Review 
Right now the error messages from dom/svg/test/test_text_2.html don't tell you what the values where that caused the failure, and in two cases the comparison is the wrong way around so that the "expected" message actually refers to the value being tested.
Attached patch patch — — Splinter Review 

        Attachment #8903094 -
        Flags: review?(jfkthame)

        Attachment #8903094 -
        Flags: review?(jfkthame) → review+

    
    

    
  
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7f2394e1cfe
Make dom/svg/test/test_text_2.html produce useful and non-inverted error messages. r=jfkthame

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/b7f2394e1cfe
Status: NEW → RESOLVED
Closed: 7 years ago

          status-firefox57:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: