Closed
Bug 1395516
Opened 8 years ago
Closed 8 years ago
releasetasks_graph_gen.py should use release-runner.yml, not ini
Categories
(Release Engineering :: Release Automation, enhancement, P1)
Release Engineering
Release Automation
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: rail)
References
Details
(Whiteboard: [releaseduty])
Attachments
(2 files)
|
59 bytes,
text/x-review-board-request
|
mtabara
:
review+
rail
:
checked-in+
|
Details |
|
50 bytes,
text/x-github-pull-request
|
mtabara
:
review+
rail
:
checked-in+
|
Details | Review |
We stopped updating the ini file and switched to yml in release runner, but not in releasetasks_graph_gen.py
| Comment hidden (mozreview-request) |
| Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8903109 -
Flags: review?(mtabara)
| Assignee | ||
Comment 3•8 years ago
|
||
It worked fine on bm83
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8903107 [details]
Bug 1395516 - releasetasks_graph_gen.py should use release-runner.yml, not ini
https://reviewboard.mozilla.org/r/174902/#review179958
We also need to remove references from puppet.
* to delete this file https://hg.mozilla.org/build/puppet/file/tip/modules/releaserunner/templates/release-runner.ini.erb
* to remove puppetization from https://hg.mozilla.org/build/puppet/file/tip/modules/releaserunner/manifests/init.pp#l67
Attachment #8903107 -
Flags: review?(mtabara) → review+
Updated•8 years ago
|
Attachment #8903109 -
Flags: review?(mtabara) → review+
Updated•8 years ago
|
Whiteboard: [releaseduty]
| Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #4)
> Comment on attachment 8903107 [details]
> Bug 1395516 - releasetasks_graph_gen.py should use release-runner.yml, not
> ini
>
> https://reviewboard.mozilla.org/r/174902/#review179958
>
> We also need to remove references from puppet.
>
> * to delete this file
> https://hg.mozilla.org/build/puppet/file/tip/modules/releaserunner/templates/
> release-runner.ini.erb
> * to remove puppetization from
> https://hg.mozilla.org/build/puppet/file/tip/modules/releaserunner/manifests/
> init.pp#l67
We still use those for "prod-old": https://hg.mozilla.org/build/puppet/file/tip/manifests/moco-config.pp#l291. I'll leave it there as is for now.
| Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8903107 [details]
Bug 1395516 - releasetasks_graph_gen.py should use release-runner.yml, not ini
https://hg.mozilla.org/build/tools/rev/8d9a5ba92c39f5eeaff96ea0acd2c5b240f6cbf8
Attachment #8903107 -
Flags: checked-in+
| Assignee | ||
Updated•8 years ago
|
Attachment #8903109 -
Flags: checked-in+
| Assignee | ||
Comment 7•8 years ago
|
||
Deployed
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 8•8 years ago
|
||
(In reply to Rail Aliiev [:rail] ⌚️UTC+3 from comment #5)
> We still use those for "prod-old":
> https://hg.mozilla.org/build/puppet/file/tip/manifests/moco-config.pp#l291.
> I'll leave it there as is for now.
You're absolutely right, mea culpa - I rushed into conclusions!
You need to log in
before you can comment on or make changes to this bug.
Description
•