Closed Bug 1395545 Opened 3 years ago Closed 3 years ago

some source map errors are not reported

Categories

(DevTools :: Framework, defect, P3)

defect

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

If the .map file for a source-mapped source is missing, it will be reported.
However, if the .map file is invalid (missing a "version" field, or even
more extreme like non-JSON content), it will not be reported.  It should be.
This turns out to happen because the worker tries to send an Error object
back using postMessage.  But, Error objects can't be cloned in this way.
The fix will have to happen in the devtools-source-map module.
Depends on: 1395613
I'm going to use this bug to land an integration test.
Comment on attachment 8903244 [details]
Bug 1395545 - test that an invalid source map is reported to the console;

https://reviewboard.mozilla.org/r/175042/#review180308

This looks good to me.
Attachment #8903244 - Flags: review?(nchevobbe) → review+
Added the eslintignore bit.
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5835416195ca
test that an invalid source map is reported to the console; r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/5835416195ca
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.