some source map errors are not reported

RESOLVED FIXED in Firefox 57

Status

()

Firefox
Developer Tools: Framework
P3
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: tromey, Assigned: tromey)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
If the .map file for a source-mapped source is missing, it will be reported.
However, if the .map file is invalid (missing a "version" field, or even
more extreme like non-JSON content), it will not be reported.  It should be.
(Assignee)

Comment 1

2 months ago
This turns out to happen because the worker tries to send an Error object
back using postMessage.  But, Error objects can't be cloned in this way.
The fix will have to happen in the devtools-source-map module.
(Assignee)

Updated

2 months ago
Depends on: 1395613
(Assignee)

Comment 2

2 months ago
I'm going to use this bug to land an integration test.
Comment hidden (mozreview-request)

Comment 4

2 months ago
mozreview-review
Comment on attachment 8903244 [details]
Bug 1395545 - test that an invalid source map is reported to the console;

https://reviewboard.mozilla.org/r/175042/#review180308

This looks good to me.
Attachment #8903244 - Flags: review?(nchevobbe) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 6

2 months ago
Added the eslintignore bit.

Comment 7

2 months ago
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5835416195ca
test that an invalid source map is reported to the console; r=nchevobbe

Comment 8

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5835416195ca
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.