1395545 - some source map errors are not reported

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P3)

Description

[Tom Tromey :tromey]

If the .map file for a source-mapped source is missing, it will be reported.
However, if the .map file is invalid (missing a "version" field, or even
more extreme like non-JSON content), it will not be reported.  It should be.

Comment 1

[Tom Tromey :tromey]

This turns out to happen because the worker tries to send an Error object
back using postMessage.  But, Error objects can't be cloned in this way.
The fix will have to happen in the devtools-source-map module.

Comment 2

[Tom Tromey :tromey]

I'm going to use this bug to land an integration test.

Comment 3

[Tom Tromey :tromey]

Attachment: Bug 1395545 - test that an invalid source map is reported to the console;

Review commit: https://reviewboard.mozilla.org/r/175042/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175042/

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8903244 [details]
Bug 1395545 - test that an invalid source map is reported to the console;

https://reviewboard.mozilla.org/r/175042/#review180308

This looks good to me.

Comment 5

[Tom Tromey :tromey]

Comment on attachment 8903244 [details]
Bug 1395545 - test that an invalid source map is reported to the console;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/175042/diff/1-2/

Comment 6

[Tom Tromey :tromey]

Added the eslintignore bit.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5835416195ca
test that an invalid source map is reported to the console; r=nchevobbe

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5835416195ca