Closed Bug 1395584 Opened 2 years ago Closed 2 years ago

Ignore js/src/vm/Opcodes.h from the coding style reformat

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 file)

js/src/vm/Opcodes.h is parsed by vm/opcode.py.
I think we should not reformat Opcodes.h for two reasons:
* the parser expects a specific format
* the code is pretty clear now, a reformat isn't probably going to improve it
Comment on attachment 8903163 [details]
Bug 1395584 - Ignore js/src/vm/Opcodes.h from the coding style reformat

https://reviewboard.mozilla.org/r/174942/#review180020

I agree, with the remark made in comment 0.
Attachment #8903163 - Flags: review?(nicolas.b.pierron) → review+
Assignee: nobody → sledru
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a8f8b47a1fe
Ignore js/src/vm/Opcodes.h from the coding style reformat r=nbp
https://hg.mozilla.org/mozilla-central/rev/0a8f8b47a1fe
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.