1395584 - Ignore js/src/vm/Opcodes.h from the coding style reformat

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Sylvestre Ledru [:Sylvestre]]

js/src/vm/Opcodes.h is parsed by vm/opcode.py.
I think we should not reformat Opcodes.h for two reasons:
* the parser expects a specific format
* the code is pretty clear now, a reformat isn't probably going to improve it

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1395584 - Ignore js/src/vm/Opcodes.h from the coding style reformat

Review commit: https://reviewboard.mozilla.org/r/174942/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174942/

Comment 2

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8903163 [details]
Bug 1395584 - Ignore js/src/vm/Opcodes.h from the coding style reformat

https://reviewboard.mozilla.org/r/174942/#review180020

I agree, with the remark made in comment 0.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8903163 [details]
Bug 1395584 - Ignore js/src/vm/Opcodes.h from the coding style reformat

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/174942/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a8f8b47a1fe
Ignore js/src/vm/Opcodes.h from the coding style reformat r=nbp

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0a8f8b47a1fe