Closed Bug 1395597 Opened 7 years ago Closed 7 years ago

"True" text at bottom of New Tab/about:newtab

Categories

(Firefox :: New Tab Page, defect)

Product:
Firefox
Component:
New Tab Page
Version:
57 Branch
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 57
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- verified

People

(Reporter: Virtual, Assigned: k88hudson)

References

Details

(Keywords: nightly-community, regression, regressionwindow-wanted)

Attachments

(1 file)

screenshot.png
109.36 KB, image/png
Details
Attached image screenshot.png — 
I got "True" text at bottom of New Tab/about:newtab.
In my case mozregression-gui failed to find regression range.
But it appeared in today Nightly, so looking on bugs which touted New Tab code, suspicious are:
bug #1392467
bug #1392468
bug #1392791

@  Fred Lin [:gasolin] - Any ideas?
Flags: needinfo?(gasolin)
From the screenshot, the inspector view shows it happens in Activity Stream's snippets view.
Component: New Tab Page → Activity Streams: Newtab
Flags: needinfo?(gasolin) → needinfo?(khudson)
according to the about:home screenshot in Bug 1395554, it might directly relate to snippet instead of AS.
Keep ni kate since you might know better who should contact with :)
Yes, this does look like an issue with snippets – I'll take a look at it.
Flags: needinfo?(khudson)
Flags: needinfo?(khudson)
This appears to be an issue originating from the snippets service (which is external to Firefox), however I have written a patch to guard against invalid payloads in the future:

https://github.com/mozilla/activity-stream/pull/3454

It appears this may have resulted from some earlier problems with the snippets API, but it looks like everything is working as expected now.
Flags: needinfo?(khudson)
https://github.com/mozilla/activity-stream/pull/3454 should be exported to MC within the next couple of days
Fixed by https://github.com/mozilla/activity-stream/pull/3454 to be uplifted via bug 1399607.
Assignee: nobody → khudson
Blocks: 1399607
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
status-firefox57: affected → fixed
Target Milestone: --- → Firefox 57
"True" text is no longer displayed at the bottom of New Tab page.
Verified as fixed using latest Nightly 57.0a1 Build ID 20170915100121, on, Windows 7 x64 Windows 10 x64 and Mac 10.12.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
As OP, I can also confirm that bug is fixed. Thanks.
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: