1395741 - Stop using SDK loader in adb-helper

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, enhancement, P1)

Description

[Alexandre Poirot [:ochameau]]

ADB Helper should stop using SDK loader.
Instead it should use the new copy from devtools, introduced in bug 1392602.

Comment 1

[Soledad Penades [:sole] [:spenades]]

Some hints on how to implement this, from conversation with Alex and Julian:

sole> How easy is it to replace adbhelper's usage of SDK loader with the new one?
jdescottes> I think it should be pretty transparent
jdescottes> looking at adbhelper's code I don't see anything used that wasn't preserved in the copy made for devtools
ochameau> it is about modifying this: https://github.com/mozilla/adbhelper/blob/master/bootstrap.js#L34-L109
ochameau> to pull the new base-loader.js from devtools if we are running on FF57, and keep the old if FF56-

Comment 2

[Julian Descottes [:jdescottes]]

Ongoing PR on GitHub: https://github.com/mozilla/adbhelper/pull/34

Comment 3

[Alexandre Poirot [:ochameau]]

Just pushed 0.11.1 version with this PR. (should take some time to propagate)

Comment 4

[Julian Descottes [:jdescottes]]

Thanks Alex, I quickly tested https://ftp.mozilla.org/pub/labs/fxos-simulator/adb-helper/mac64/adbhelper-0.11.1-mac64.xpi on both Nightly and Beta, and looks like it's working fine.