Closed Bug 1395741 Opened 4 years ago Closed 4 years ago
Stop using SDK loader in adb-helper
ADB Helper should stop using SDK loader. Instead it should use the new copy from devtools, introduced in bug 1392602.
Some hints on how to implement this, from conversation with Alex and Julian: sole> How easy is it to replace adbhelper's usage of SDK loader with the new one? jdescottes> I think it should be pretty transparent jdescottes> looking at adbhelper's code I don't see anything used that wasn't preserved in the copy made for devtools ochameau> it is about modifying this: https://github.com/mozilla/adbhelper/blob/master/bootstrap.js#L34-L109 ochameau> to pull the new base-loader.js from devtools if we are running on FF57, and keep the old if FF56-
Priority: -- → P2
Whiteboard: [nosdk] [triage] → [nosdk]
Ongoing PR on GitHub: https://github.com/mozilla/adbhelper/pull/34
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Just pushed 0.11.1 version with this PR. (should take some time to propagate)
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Thanks Alex, I quickly tested https://ftp.mozilla.org/pub/labs/fxos-simulator/adb-helper/mac64/adbhelper-0.11.1-mac64.xpi on both Nightly and Beta, and looks like it's working fine.
You need to log in before you can comment on or make changes to this bug.