1395773 - Intermittent browser_datetime_datepicker.js | "August 2017" == "September 2017" - JS frame :: chrome://mochitests/content/browser/toolkit/content/tests/browser/browser_datetime_datepicker.js :: test_datepicker_today :: line 57

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: rvandermeulen [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=127563469&repo=try

https://queue.taskcluster.net/v1/task/f4gwkVWtTtKGN9soqomYxg/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Looks like we've got a new timebomb test (one that fails when it happens to run at just the right time to hit a change in month mid-run).

Comment 2

[Scott Wu [:scottwu]]

Attachment: Bug 1395773 - Fix intermittent browser_datetime_datepicker test when crossing months,

Review commit: https://reviewboard.mozilla.org/r/175312/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175312/

Comment 3

[Scott Wu [:scottwu]]

Thanks for filing the bug. Turns out this doesn't just happen when month changes mid-run, but hours leading up to the month change. In this particular test, DateTimeFormat was set to UTC, when it should have been local time. So at 8/31 17:01 pacific daylight time, the month string becomes `September` rather than `August`.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

thanks for working on this :scottwu!

Comment 5

[Intermittent Failures Robot]

77 failures in 180 pushes (0.428 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* autoland: 37
* try: 25
* mozilla-inbound: 15

Platform breakdown:
* windows8-64: 35
* osx-10-10: 32
* macosx64-stylo: 6
* macosx64-nightly: 2
* macosx64-devedition: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1395773&startday=2017-09-01&endday=2017-09-01&tree=all

Comment 6

[Intermittent Failures Robot]

101 failures in 939 pushes (0.108 failures/push) were associated with this bug in the last 7 days. 

This is the #19 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 47
* try: 26
* mozilla-inbound: 21
* mozilla-central: 7

Platform breakdown:
* windows8-64: 49
* osx-10-10: 40
* macosx64-stylo: 7
* macosx64-devedition: 3
* macosx64-nightly: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1395773&startday=2017-08-28&endday=2017-09-03&tree=all

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8903474 [details]
Bug 1395773 - Fix intermittent browser_datetime_datepicker test when crossing months,

https://reviewboard.mozilla.org/r/175312/#review181784

Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f99a4070d320
Fix intermittent browser_datetime_datepicker test when crossing months, r=mconley

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f99a4070d320