Closed Bug 1395773 Opened 7 years ago Closed 7 years ago

Intermittent browser_datetime_datepicker.js | "August 2017" == "September 2017" - JS frame :: chrome://mochitests/content/browser/toolkit/content/tests/browser/browser_datetime_datepicker.js :: test_datepicker_today :: line 57

Categories

(Core :: Layout: Form Controls, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: scottwu)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:logic])

Attachments

(1 file)

Looks like we've got a new timebomb test (one that fails when it happens to run at just the right time to hit a change in month mid-run).
Flags: needinfo?(scwwu)
Flags: needinfo?(mconley)
Thanks for filing the bug. Turns out this doesn't just happen when month changes mid-run, but hours leading up to the month change. In this particular test, DateTimeFormat was set to UTC, when it should have been local time. So at 8/31 17:01 pacific daylight time, the month string becomes `September` rather than `August`.
Flags: needinfo?(scwwu)
Flags: needinfo?(mconley)
Assignee: nobody → scwwu
Status: NEW → ASSIGNED
thanks for working on this :scottwu!
Whiteboard: [stockwell needswork]
Attachment #8903474 - Flags: review?(mconley)
Comment on attachment 8903474 [details]
Bug 1395773 - Fix intermittent browser_datetime_datepicker test when crossing months,

https://reviewboard.mozilla.org/r/175312/#review181784

Thanks!
Attachment #8903474 - Flags: review?(mconley) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f99a4070d320
Fix intermittent browser_datetime_datepicker test when crossing months, r=mconley
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f99a4070d320
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Whiteboard: [stockwell needswork] → [stockwell fixed:logic]
You need to log in before you can comment on or make changes to this bug.