|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
[Tracking Requested - why for this release]: Permafailing test on the next merge day. https://treeherder.mozilla.org/logviewer.html#?job_id=127569863&repo=try TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_controller_onDrop.js | Uncaught exception - at resource://gre/modules/PlacesUtils.jsm:2708 - TypeError: txn is null Stack trace: countTransactions@resource://gre/modules/PlacesUtils.jsm:2708:1 PlacesAggregatedTransaction@resource://gre/modules/PlacesUtils.jsm:2714:18 onDrop@chrome://browser/content/places/controller.js:1666:17 Tester_execTest@chrome://mochikit/content/browser-test.js:794:9 Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:694:7 SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59 Can likely be reproduced locally and on Try by applying this patch: https://hg.mozilla.org/try/rev/82850c4a96bd343562c2737f8b220921c99473b0 If that doesn't work, this one might also be needed: https://hg.mozilla.org/try/rev/76355f8530ac77edf4d5cc8c7cc7d4672f3efe8e
This is most likely because we haven't yet flipped the switch for enabling async transactions on non-nightly (bug 979280) - the test is broken for the old sync transactions. That's not a surprise, though I'd prefer to avoid the extra work for something we're hopefully going to be turning off.
Can we just skip the test if async transactions are not enabled?
Comment on attachment 8904209 [details] Bug 1395784 - Skip browser_controller_onDrop.js when async places transactions are turned off. https://reviewboard.mozilla.org/r/175990/#review181018
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/4ee1eca7adbd Skip browser_controller_onDrop.js when async places transactions are turned off. r=mak