Closed
Bug 1395802
Opened 7 years ago
Closed 7 years ago
Don't use lock when accessing ChannelMediaResource::mChannelStatistics
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(4 files)
59 bytes,
text/x-review-board-request
|
cpearce
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
cpearce
:
review+
|
Details |
Bug 1395802. P4 - we don't need lock since mChannelStatistics is always accessed on the main thread.
59 bytes,
text/x-review-board-request
|
cpearce
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
cpearce
:
review+
|
Details |
Before fixing bug 1395793, we want to simplify the locking model of ChannelMediaResource.
Assignee | ||
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8904817 -
Flags: review?(cpearce)
Attachment #8904818 -
Flags: review?(cpearce)
Attachment #8904819 -
Flags: review?(cpearce)
Assignee | ||
Updated•7 years ago
|
Attachment #8904817 -
Flags: review?(cpearce)
Attachment #8904818 -
Flags: review?(cpearce)
Attachment #8904819 -
Flags: review?(cpearce)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8905089 -
Flags: review?(cpearce)
Attachment #8904817 -
Flags: review?(cpearce)
Attachment #8904818 -
Flags: review?(cpearce)
Attachment #8904819 -
Flags: review?(cpearce)
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8904817 [details] Bug 1395802. P2 - assert ChannelMediaResource::GetDownloadRate() runs on the main thread. https://reviewboard.mozilla.org/r/176570/#review182184
Attachment #8904817 -
Flags: review?(cpearce) → review+
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8905089 [details] Bug 1395802. P1 - add AbstractMainThread() to MediaResourceCallback. https://reviewboard.mozilla.org/r/176902/#review182186
Attachment #8905089 -
Flags: review?(cpearce) → review+
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8904818 [details] Bug 1395802. P3 - ensure mChannelStatistics.AddBytes() to happen on the main thread. https://reviewboard.mozilla.org/r/176572/#review182188
Attachment #8904818 -
Flags: review?(cpearce) → review+
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8904819 [details] Bug 1395802. P4 - we don't need lock since mChannelStatistics is always accessed on the main thread. https://reviewboard.mozilla.org/r/176574/#review182190
Attachment #8904819 -
Flags: review?(cpearce) → review+
Assignee | ||
Comment 12•7 years ago
|
||
Thanks!
Comment 13•7 years ago
|
||
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/23fd25a4f713 P1 - add AbstractMainThread() to MediaResourceCallback. r=cpearce https://hg.mozilla.org/integration/autoland/rev/8bfe3fa7b4f1 P2 - assert ChannelMediaResource::GetDownloadRate() runs on the main thread. r=cpearce https://hg.mozilla.org/integration/autoland/rev/a70f47912fbe P3 - ensure mChannelStatistics.AddBytes() to happen on the main thread. r=cpearce https://hg.mozilla.org/integration/autoland/rev/6469a2cb7df6 P4 - we don't need lock since mChannelStatistics is always accessed on the main thread. r=cpearce
Comment 14•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/23fd25a4f713 https://hg.mozilla.org/mozilla-central/rev/8bfe3fa7b4f1 https://hg.mozilla.org/mozilla-central/rev/a70f47912fbe https://hg.mozilla.org/mozilla-central/rev/6469a2cb7df6
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•