Tighten up assertions in ChannelSuspendAgent

RESOLVED FIXED in Firefox 57

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
ChannelSuspendAgent is used on the main thread only and mSuspendCount doesn't need to be a atomic [1].

[1] http://searchfox.org/mozilla-central/rev/51b3d67a5ec1758bd2fe7d7b6e75ad6b6b5da223/dom/media/MediaResource.h#402
Assignee

Updated

2 years ago
Assignee: nobody → jwwang
Blocks: 1382978
Priority: -- → P3
Assignee

Updated

2 years ago
Attachment #8904821 - Flags: review?(alwu)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8904821 [details]
Bug 1395842 - tighten up assertions in ChannelSuspendAgent which runs on the main thread only.

https://reviewboard.mozilla.org/r/176582/#review181636
Attachment #8904821 - Flags: review?(alwu) → review+
Assignee

Comment 3

2 years ago
Thanks!

Comment 4

2 years ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a2a1ce612e91
tighten up assertions in ChannelSuspendAgent which runs on the main thread only. r=alwu

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a2a1ce612e91
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee

Updated

2 years ago
Blocks: 1428688
Assignee

Updated

2 years ago
No longer blocks: 1428688
You need to log in before you can comment on or make changes to this bug.