Closed Bug 1395842 Opened 6 years ago Closed 6 years ago

Tighten up assertions in ChannelSuspendAgent

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

Product:
Core
Component:
Audio/Video: Playback
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

Bug 1395842 - tighten up assertions in ChannelSuspendAgent which runs on the main thread only.
59 bytes, text/x-review-board-request
alwu
: review+
Details 
ChannelSuspendAgent is used on the main thread only and mSuspendCount doesn't need to be a atomic [1].

[1] http://searchfox.org/mozilla-central/rev/51b3d67a5ec1758bd2fe7d7b6e75ad6b6b5da223/dom/media/MediaResource.h#402
Assignee: nobody → jwwang
Blocks: 1382978
Priority: -- → P3
Attachment #8904821 - Flags: review?(alwu)
Comment on attachment 8904821 [details]
Bug 1395842 - tighten up assertions in ChannelSuspendAgent which runs on the main thread only.

https://reviewboard.mozilla.org/r/176582/#review181636
Attachment #8904821 - Flags: review?(alwu) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a2a1ce612e91
tighten up assertions in ChannelSuspendAgent which runs on the main thread only. r=alwu
https://hg.mozilla.org/mozilla-central/rev/a2a1ce612e91
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Blocks: 1428688
No longer blocks: 1428688
You need to log in before you can comment on or make changes to this bug.