Closed
Bug 1395855
Opened 7 years ago
Closed 7 years ago
Data race in accessing mOffset in ChannelMediaResource::CopySegmentToCache()
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(2 files)
mOffset is a main thread only member but ChannelMediaResource::CopySegmentToCache() will run off the main thread when OMT data delivery is enabled.
Assignee | ||
Comment 1•7 years ago
|
||
http://searchfox.org/mozilla-central/rev/51b3d67a5ec1758bd2fe7d7b6e75ad6b6b5da223/dom/media/MediaResource.cpp#460-461
Assignee | ||
Comment 2•7 years ago
|
||
Since most accesses to mOffset happen on the main thread, we will dispatch a task to update mOffset on the main thread in ChannelMediaResource::CopySegmentToCache().
Assignee | ||
Comment 3•7 years ago
|
||
It turns out that we can just remove the member to avoid the data race.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8906518 -
Flags: review?(cpearce)
Attachment #8906519 -
Flags: review?(cpearce)
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8906518 [details] Bug 1395855. P1 - remove ChannelMediaResource::mOffset so we have less data race to worry about. https://reviewboard.mozilla.org/r/178272/#review183536
Attachment #8906518 -
Flags: review?(cpearce) → review+
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8906519 [details] Bug 1395855. P2 - store the offset of range request. https://reviewboard.mozilla.org/r/178274/#review183538
Attachment #8906519 -
Flags: review?(cpearce) → review+
Assignee | ||
Comment 8•7 years ago
|
||
Thanks!
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/803f854237c1 P1 - remove ChannelMediaResource::mOffset so we have less data race to worry about. r=cpearce https://hg.mozilla.org/integration/autoland/rev/951c770131ae P2 - store the offset of range request. r=cpearce
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/803f854237c1 https://hg.mozilla.org/mozilla-central/rev/951c770131ae
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•