1395858 - Crash in nsTArray_Impl<T>::AppendElement<T> | mozilla::Preferences::AddAtomicUintVarCache<T>

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is 
report bp-0e117a4c-85ee-41ef-9865-aa6560170901.
=============================================================

There are 192 crashes in nightly 57 with buildid 20170831220208. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1395139.

[1] https://hg.mozilla.org/mozilla-central/rev?node=c9079d347aaa559beecf0db6e5414f92ef043485

Comment 1

[Calixte Denizet (:calixte)]

This signature is ranked #2 in GPU process top-crashers.

Comment 2

[Marcia Knous [:marcia]]

We now have over 500 crashes in the signature. Since we are close to the weekend, it probably would be preferable to back this patch out.

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1395858 - Use gfxPrefs to read AMD VP9 preference.

MediaPrefs isn't initialised in the GPU process, so use gfxPrefs instead.

Review commit: https://reviewboard.mozilla.org/r/175390/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175390/

Comment 4

[Jean-Yves Avenard [:jya]]

This is a GPU process crash, it will then automatically be restarted and the hardware decoder will be restarted.

It will be transparent to the user.

Comment 5

[Paul Adenot (:padenot)]

Comment on attachment 8903620 [details]
Bug 1395858 - Use gfxPrefs to read AMD VP9 preference.

https://reviewboard.mozilla.org/r/175390/#review180516

Comment 6

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 55b5ba62e412 -d 7b9b68b275c9: rebasing 417338:55b5ba62e412 "Bug 1395858 - Use gfxPrefs to read AMD VP9 preference. r=padenot" (tip)
merging dom/media/MediaPrefs.h
merging dom/media/platforms/wmf/WMFDecoderModule.cpp
merging dom/media/platforms/wmf/WMFVideoMFTManager.cpp
merging gfx/thebes/gfxPrefs.h
warning: conflicts while merging gfx/thebes/gfxPrefs.h! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 7

[Jean-Yves Avenard [:jya]]

Comment on attachment 8903620 [details]
Bug 1395858 - Use gfxPrefs to read AMD VP9 preference.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/175390/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bafae81b6c52
Use gfxPrefs to read AMD VP9 preference. r=padenot

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bafae81b6c52

Comment 10

[Nicholas Nethercote [inactive]]

This was the #1 Windows topcrash in Nightly 20170901100309. It is not present in Nightly 20170901220209, yay.