1395873 - Changes in bug 1361639 caused some deadcode in SVGTransformableElement::GetAnimatedTransformList

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1395870 +++

   intervals: At condition flags == nsSVGUtils::eBBoxIncludeMarkers, the value of flags must be in one of the following intervals: {[512,513], [516,517], [528,529], [532,533], [544,545], [548,549], [560,561], [564,565]}.
   dead_error_condition: The condition flags == nsSVGUtils::eBBoxIncludeMarkers cannot be true.
   dead_error_condition: The condition flags == nsSVGUtils::eBBoxIncludeClipped cannot be true.
211    if (flags == nsSVGUtils::eBBoxIncludeMarkers ||
   intervals: At condition flags == nsSVGUtils::eBBoxIncludeClipped, the value of flags must be in one of the following intervals: {[512,513], [516,517], [528,529], [532,533], [544,545], [548,549], [560,561], [564,565]}.
212        flags == nsSVGUtils::eBBoxIncludeClipped) {
   CID 1417207 (#2 of 2): Logically dead code (DEADCODE)dead_error_line: Execution cannot reach this statement: flags |= nsSVGUtils::eBBoxI....
213      flags |= nsSVGUtils::eBBoxIncludeFill;
214    }

Not sure what to do here, should remove it?

Comment 1

[Sylvestre Ledru [:Sylvestre]]

cjku, what do you think?

Comment 2

[u459114]

Attachment: Bug 1395873 - Append eUseUserSpaceOfUseElement flag after all standard SVGBoundingBoxOptions checked.

Review commit: https://reviewboard.mozilla.org/r/175386/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175386/

Comment 3

[Sylvestre Ledru [:Sylvestre]]

The patch will conflict with what landed in bug 1395870

Comment 4

[u459114]

Yes, I think we should rollback the change in bug 1395870. I can do it here

Comment 5

[u459114]

(In reply to Sylvestre Ledru [:sylvestre] from comment #3)
> The patch will conflict with what landed in bug 1395870

I will rebase on your patch before landing(or just wait autoland repo be merged back to central, and rebase on central)

Comment 6

[u459114]

Comment on attachment 8903601 [details]
Bug 1395873 - Append eUseUserSpaceOfUseElement flag after all standard SVGBoundingBoxOptions checked.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/175386/diff/1-2/

Comment 7

[u459114]

Rebased

Comment 8

[Robert Longson [:longsonr]]

Comment on attachment 8903601 [details]
Bug 1395873 - Append eUseUserSpaceOfUseElement flag after all standard SVGBoundingBoxOptions checked.

https://reviewboard.mozilla.org/r/175386/#review180566

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00b9a3c8a7fd
Append eUseUserSpaceOfUseElement flag after all standard SVGBoundingBoxOptions checked. r=longsonr+218550

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/00b9a3c8a7fd