Closed
Bug 1395873
Opened 7 years ago
Closed 7 years ago
Changes in bug 1361639 caused some deadcode in SVGTransformableElement::GetAnimatedTransformList
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: u459114)
References
(Blocks 2 open bugs)
Details
(Keywords: coverity, Whiteboard: [CID 1417207])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1395870 +++ intervals: At condition flags == nsSVGUtils::eBBoxIncludeMarkers, the value of flags must be in one of the following intervals: {[512,513], [516,517], [528,529], [532,533], [544,545], [548,549], [560,561], [564,565]}. dead_error_condition: The condition flags == nsSVGUtils::eBBoxIncludeMarkers cannot be true. dead_error_condition: The condition flags == nsSVGUtils::eBBoxIncludeClipped cannot be true. 211 if (flags == nsSVGUtils::eBBoxIncludeMarkers || intervals: At condition flags == nsSVGUtils::eBBoxIncludeClipped, the value of flags must be in one of the following intervals: {[512,513], [516,517], [528,529], [532,533], [544,545], [548,549], [560,561], [564,565]}. 212 flags == nsSVGUtils::eBBoxIncludeClipped) { CID 1417207 (#2 of 2): Logically dead code (DEADCODE)dead_error_line: Execution cannot reach this statement: flags |= nsSVGUtils::eBBoxI.... 213 flags |= nsSVGUtils::eBBoxIncludeFill; 214 } Not sure what to do here, should remove it?
Comment hidden (mozreview-request) |
Reporter | ||
Comment 3•7 years ago
|
||
The patch will conflict with what landed in bug 1395870
Attachment #8903601 -
Flags: review?(sledru)
Comment hidden (spam) |
(In reply to Sylvestre Ledru [:sylvestre] from comment #3) > The patch will conflict with what landed in bug 1395870 I will rebase on your patch before landing(or just wait autoland repo be merged back to central, and rebase on central)
Comment hidden (mozreview-request) |
Attachment #8903601 -
Flags: review?(longsonr)
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8903601 [details] Bug 1395873 - Append eUseUserSpaceOfUseElement flag after all standard SVGBoundingBoxOptions checked. https://reviewboard.mozilla.org/r/175386/#review180566
Attachment #8903601 -
Flags: review?(longsonr) → review+
Attachment #8903601 -
Flags: review?(sledru)
Pushed by cku@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/00b9a3c8a7fd Append eUseUserSpaceOfUseElement flag after all standard SVGBoundingBoxOptions checked. r=longsonr+218550
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/00b9a3c8a7fd
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•