Closed Bug 1395897 Opened 4 years ago Closed 4 years ago

certutil shouldn't prompt for password if -f is given

Categories

(NSS :: Libraries, enhancement)

3.32
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: KaiE, Assigned: KaiE)

Details

Attachments

(1 file)

parameter certutil -f doesn't work in all scenarios.

This bug attempts to fix a scenario we found, by passing on the password context to worker functions.

While I was there, I extended two additional functions, which were easy to do.

Also, I removed two dead functions.
Assignee: dueno → kaie
Attached patch 1395897-v1.patchSplinter Review
Attachment #8903541 - Flags: review?(rrelyea)
Comment on attachment 8903541 [details] [diff] [review]
1395897-v1.patch

Review of attachment 8903541 [details] [diff] [review]:
-----------------------------------------------------------------

This is a good change. It's not just certutil that can benefit. Anything that uses the password arg will work better with these changes.
Attachment #8903541 - Flags: review?(rrelyea) → review+
https://hg.mozilla.org/projects/nss/rev/69f83c64dec4
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
This change might have potentially been too late for the NSS 3.33 release. If it gets excluded, we must remember to change the version in nss.def to 3.34
Flags: needinfo?(kaie)
It will be in 3.33
Flags: needinfo?(kaie)
You need to log in before you can comment on or make changes to this bug.