1395902 - Incorrect sample for Using the span keyword in Line-based placement with CSS Grid docs

Status: RESOLVED FIXED

(Developer Documentation Graveyard :: CSS, enhancement, P5)

Description

[joseantonio.blanco]

:: Developer Documentation Request

      Request Type: Correction
     Gecko Version: unspecified
 Technical Contact: 

:: Details

In the "Using the span keyword" section, the last paragraphs explain the span syntax when using grid-row-start/end and grid-column-start/end, but the examples are not correct.

The first example, that reads:

.box1 {
    grid-column-start: 1;
    grid-row-start: 1 /  span 3;
}

should be either:

.box1 {
    grid-column-start: 1;
    grid-row: 1 /  span 3;
}

or: 

.box1 {
    grid-column-start: 1;
    grid-row-start: 1;
    grid-row-end: span 3;
}

Similar correction applies to the second example.
Hopefully this means that I've properly understood the spec :)
Thanks.

Comment 1

[Chris Mills [:cmills]]

Hi there Jose,

You are absolutely correct that this was wrong. The examples were trying to apply grid-row shorthand values to the grid-row-start longhand property!

I've updated them to something that I think makes a lot more sense. Do you think this is OK? 

Thanks for reporting this!

Comment 2

[joseantonio.blanco]

Hi Cris,

Perfect, now both variations of the syntax are properly explained. Thanks for fixing this, and congrats on the docs. If I was able to detect the error, is because the MDN documentation helped me a lot to understand the grid spec.
Thanks!

Comment 3

[Chris Mills [:cmills]]

Cool, I'm so glad you like the docs! Thanks again.

Closing this one now.