Execute in-tree unit tests for geckodriver

RESOLVED FIXED in Firefox 59

Status

P3
normal
RESOLVED FIXED
a year ago
10 months ago

People

(Reporter: whimboo, Assigned: ato)

Tracking

57 Branch
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

a year ago
Since geckodriver landed in-tree and we build it via Taskcluster on various platforms the integrated Rust unit tests are no longer executed. I just noticed that myself by running `cargo test` locally.

Andreas, looks like we missed to add the execution of those beside just building geckodriver.
Flags: needinfo?
(Reporter)

Updated

a year ago
Flags: needinfo? → needinfo?(ato)
(Assignee)

Comment 1

a year ago
We didn’t miss it.  It needs to be done.
Flags: needinfo?(ato)
(Reporter)

Comment 2

a year ago
I see. So this should now apply to both geckodriver and webdriver-rust.
Summary: Unit tests for geckodriver no longer executed since in-tree landing → Execute in-tree unit tests for webdriver-rust/geckodriver
(Reporter)

Updated

a year ago
Depends on: 1331022
Priority: -- → P3
(Assignee)

Updated

11 months ago
Assignee: nobody → ato
Status: NEW → ASSIGNED
(Assignee)

Comment 3

11 months ago
I’m going to split the work of getting the webdriver crate Rust
tests running out to a separate bug because it is a problem to mach
that it is not a separately vendored crate in m-c.  I’ve filed bug
https://bugzil.la/1424369 about this.
Summary: Execute in-tree unit tests for webdriver-rust/geckodriver → Execute in-tree unit tests for geckodriver
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 6

11 months ago
mozreview-review
Comment on attachment 8935891 [details]
Bug 1395933 - Run geckodriver tests in automation.

https://reviewboard.mozilla.org/r/206760/#review212574

r=me assuming it passes tests.
Attachment #8935891 - Flags: review?(giles) → review+

Comment 7

11 months ago
mozreview-review
Comment on attachment 8935892 [details]
Bug 1395933 - Expand geckodriver mach command with test and build targets.

https://reviewboard.mozilla.org/r/206762/#review212580

::: testing/geckodriver/CONTRIBUTING.md:157
(Diff revision 1)
>  a set of conformance tests with other browser vendors through the
>  [Web Platform Tests] (WPT) initiative.  This lets us ensure web
>  compatibility between _different_ WebDriver implementations for
>  different browsers.
>  
> -In addition to the WPT tests, geckodriver and libwebdriver has
> +In addition to the WPT tests, geckodriver and webdriver has unit tests.

`geckodriver and webdriver *have* unit tests` for correct number agreement.

::: testing/geckodriver/CONTRIBUTING.md:162
(Diff revision 1)
> -you need to kick off a separate build using [cargo]:
>  
> -	% cd testing/geckodriver
> +	% ./mach geckodriver test
> -	   Compiling geckodriver v0.19.0 (file:///home/ato/src/gecko/testing/geckodriver)
>  	…
> -	test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
> +	 0:02.39 test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

Did you mean to add the runtime to the documented output here?
Attachment #8935892 - Flags: review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

10 months ago
Attachment #8935892 - Flags: review?(dburns) → review?(mjzffr)
(Assignee)

Comment 10

10 months ago
rillian: Thanks for all your useful input.  I’ve addressed your
concerns about testing/geckodriver/CONTRIBUTING.md.

There are some compile failures with winapi on windows2012, but
rebased and triggered a new try build to make sure they are real.

Comment 11

10 months ago
mozreview-review
Comment on attachment 8935892 [details]
Bug 1395933 - Expand geckodriver mach command with test and build targets.

https://reviewboard.mozilla.org/r/206762/#review213036
Attachment #8935892 - Flags: review?(mjzffr) → review+
(Assignee)

Comment 13

10 months ago
The instability of the Windows jobs seems to an unrelated issue to
the changes I am making in this changeset.  There is a intermittent
filed in https://bugzilla.mozilla.org/show_bug.cgi?id=1420472.

Comment 14

10 months ago
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7827a7002f94
Run geckodriver tests in automation. r=rillian
https://hg.mozilla.org/integration/autoland/rev/81228d9e87e5
Expand geckodriver mach command with test and build targets. r=maja_zf,rillian
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 20

10 months ago
I forgot to update the patches that were on mozreview.  The problems
had been fixed in my local branch.

New try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7a06fa1f65c49e769b619574abc910ea4613511
Flags: needinfo?(ato)

Comment 22

10 months ago
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c394ade418a
Run geckodriver tests in automation. r=rillian
https://hg.mozilla.org/integration/autoland/rev/dfba797e7a1f
Expand geckodriver mach command with test and build targets. r=maja_zf,rillian

Comment 23

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7c394ade418a
https://hg.mozilla.org/mozilla-central/rev/dfba797e7a1f
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
(Assignee)

Updated

10 months ago
Blocks: 1425365
You need to log in before you can comment on or make changes to this bug.