top level data: url loading blocking happens too late

RESOLVED FIXED in Firefox 57

Status

()

enhancement
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: smaug, Assigned: ckerschb)

Tracking

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Assignee: nobody → ckerschb
Blocks: 1331351
Status: NEW → ASSIGNED
Priority: -- → P2
Reporter

Comment 2

2 years ago
Comment on attachment 8904332 [details] [diff] [review]
bug_1395948_data_block_too_late.patch

Would be nice to have a test for this, especially given that we didn't catch this issue earlier.
Attachment #8904332 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] from comment #2)
> Would be nice to have a test for this, especially given that we didn't catch
> this issue earlier.

Well, we have:
* browser_test_toplevel_data_navigations.js
* test_block_toplevel_data_navigation.html
but I agree that those tests are not explicitly about checking whether the window itself got created. I filed Bug 1396749 to think about all the different use cases again.

Comment 4

2 years ago
Pushed by mozilla@christophkerschbaumer.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4270e8daf3cf
Move blocking of toplevel data: URI navigations before opening a new window. r=smaug
(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #5)
> Backed out for build bustage at docshell/base/nsDocShellLoadTypes.h:22:

Ah, this is an enum, so we can simply do:
  bool loadFromExternal = (aLoadType == LOAD_NORMAL_EXTERNAL);
like we do elsewhere within nsDocshell.
Flags: needinfo?(ckerschb)

Comment 7

2 years ago
Pushed by mozilla@christophkerschbaumer.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/74d087bee9e5
Move blocking of toplevel data: URI navigations before opening a new window. r=smaug
https://hg.mozilla.org/mozilla-central/rev/74d087bee9e5
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.