Closed
Bug 1395949
Opened 7 years ago
Closed 7 years ago
another speedometer regression on Aug 31
Categories
(Core :: DOM: Core & HTML, defect, P2)
Tracking
()
RESOLVED
INCOMPLETE
People
(Reporter: bkelly, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: regression, regressionwindow-wanted)
We have another AWFT speedometer regression on Aug 31: https://arewefastyet.com/#machine=36&view=single&suite=speedometer-misc&subtest=React-Redux-TodoMVC-Adding100Items-sync It claims this changeset, but I don't trust that its correct: https://hg.mozilla.org/integration/mozilla-inbound/log?rev=2bf1d0e361ab1ad935b61796520b118064d33a39%3A%3A82052535770fac7ba6000e7c0c5e83b2fddf6101%20and%20!2bf1d0e361ab1ad935b61796520b118064d33a39 We probably need a regression range. I believe we can use this URL to try to reproduce: https://mozilla.github.io/arewefastyet-speedometer/2.0/InteractiveRunner.html?suite=React-Redux-TodoMVC
Reporter | ||
Comment 1•7 years ago
|
||
To clarify, I don't have time to do the bisect myself today. Sorry.
Comment 2•7 years ago
|
||
Ryan, do we have someone with cycles to bisect the regression range?
Flags: needinfo?(ryanvm)
Reporter | ||
Comment 3•7 years ago
|
||
It would be great if we could do bug 1022714 so we didn't have to manually bisect regressions here.
Comment 4•7 years ago
|
||
This looks like a really noisy test. Other than one obvious outlier, I'm having a hard time seeing the regression? https://arewefastyet.com/#machine=36&view=single&suite=speedometer-misc&subtest=React-Redux-TodoMVC-Adding100Items-sync&start=1504043590&end=1504280359
Flags: needinfo?(ryanvm)
Reporter | ||
Comment 5•7 years ago
|
||
Ok, maybe its noise.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Reporter | ||
Comment 6•7 years ago
|
||
Well, there is still something regressed I think. On August 29/30 we were getting better numbers than we are today. PGO was getting 86-to-88, but not we are getting 85-to-86. https://arewefastyet.com/#machine=36&view=single&suite=speedometer-misc&subtest=score
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Comment 7•7 years ago
|
||
We're now oscillating between 87 to 86... https://arewefastyet.com/#machine=36&view=single&suite=speedometer-misc&subtest=score&start=1502491033&end=1604295235
Reporter | ||
Comment 8•7 years ago
|
||
That chart is ignoring Aug 31 and Sep 1. See the chart without the end date restriction: https://arewefastyet.com/#machine=36&view=single&suite=speedometer-misc&subtest=score
Comment 9•7 years ago
|
||
Yeah you're right... So anecdotally for a while the PGO numbers were stable at 84. Not sure what to make of the fact that they're not quite back to what they were before bug 1395727 was introduced... :-(
Comment 10•7 years ago
|
||
I wonder, could it be bug 1393597.
Reporter | ||
Comment 11•7 years ago
|
||
Looking at the breakdown graphs, maybe things have more variability since August 29/30. Its really hard to tell, though, given we had a day of regression introducing variability itself.
Summary: another speedometer regression on Aug 31 on React-Redux-TodoMVC-Adding100Items-sync → another speedometer regression on Aug 31
Reporter | ||
Comment 12•7 years ago
|
||
Now that AWFY is updating again its a bit easier to see if there is a stable regression. Win 8 64-bit (i7-4700HQ, browser) Ion: Aug 30: ~113 Sep 1 to 4: ~110 to 111 Quantum Reference (Windows, browser, x64) Ion: Aug 30: ~78 Sep 1 to 4: ~78 to 79 This is a bit odd in that the slower machine doesn't show any regression, but the faster machine does. Perhaps whatever changed is not a CPU perf regression but more firefox using idle time less efficiently. Anyway, its unclear to me if there is anything we can do here. Maybe we should just WONTFIX this bug and just keep on trying to improve the benchmark in general.
Updated•7 years ago
|
Priority: -- → P1
Comment 13•7 years ago
|
||
CCing Jan to see if he has any thoughts.
Comment 14•7 years ago
|
||
(In reply to :Ehsan Akhgari (needinfo please, extremely long backlog, Away until Sep 12) from comment #13) > CCing Jan to see if he has any thoughts. Not really, offhand. It might be this: (In reply to Olli Pettay [:smaug] from comment #10) > I wonder, could it be bug 1393597. But that's just a guess and it's also a fix we really want to keep for responsiveness.
Comment 15•7 years ago
|
||
Given the change to the scoring it's hard to see a trend here but I'm tempted to WONTFIX since we're still making progress elsewhere. At a minimum, I'm going to mark as P2.
Priority: P1 → P2
Comment 16•7 years ago
|
||
I think let's close it for now, unless if someone finds out evidence that something caused a regression somewhere...
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → INCOMPLETE
Assignee | ||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•