1395982 - All kinds of flickering on Mac

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Jeff Muizelaar [:jrmuizel]]

This is with todays nightly and layers-free. It seems to be a recent regression.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

I'll try to narrow down what broke it.

Comment 2

[Aria Beingessner [:Gankra]]

I can confirm I was seeing this in my local build; I just assumed I had broken something.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

I can confirm that this worked before the update to webrender 81cba6b139c4c1061cab6a1c38acf2ae7f50445d

Comment 4

[Jeff Muizelaar [:jrmuizel]]

And can confirm that it was that update that caused the flickering.

Comment 5

[Aria Beingessner [:Gankra]]

Binary search says: https://github.com/servo/webrender/pull/1635 is the culprit.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

It seems like https://github.com/servo/webrender/pull/1635 may have just changed the symptoms. https://github.com/servo/webrender/pull/1625 broke shadow rendering for me on Mac.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

i.e. this renders without a shadow. (After the a8 change it renders with a solid black shadow)
---
root:
  items:
        - type: stacking-context
          bounds: [0, 0, 600, 600]
          items:
            - type: box-shadow
              bounds: [ 40, 40, 400, 400 ]
              blur-radius: 12
              color: black

Comment 8

[ibrokemypie]

Very recent, just re-enabled webrender to check https://bugzilla.mozilla.org/show_bug.cgi?id=1391689 is fixed and noticed this issue. Was not present earlier.

Comment 9

[Aria Beingessner [:Gankra]]

We fixed this in https://github.com/servo/webrender/pull/1666, which has landed on central. 

I don't see it in the very latest nightly.

Comment 10

[ibrokemypie]

Still happening for me on 57.0a1 (2017-09-09) (64-bit), though not quite as much, but basically whenever the screen updates, such as when scrolling or typing.