1396000 - Clean up aboutTelemetry.dtd format

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement)

Description

[Francesco Lodolo [:flod]]

aboutTelemetry.dtd is the only file in the the tree that uses this weird format

<!ENTITY aboutTelemetry.pingDataSource "
Ping data source:
">

Instead of just

<!ENTITY aboutTelemetry.pingDataSource "Ping data source:">

Line feeds are meaningful in a DTD file, so the string includes them and they're exposed in localization tools, but have no practical effect when the string is displayed in a HTML document.

Any objection in cleaning up the file and dropping all the unnecessary line feeds?

Comment 1

[Francesco Lodolo [:flod]]

You're the one who's been touching this file more frequently (in terms of reviewer) in the past week. Not sure if someone else should own the decision.

Comment 2

[Chris H-C :chutten]

I have no objection. I also like consistency :)

Comment 3

[Francesco Lodolo [:flod]]

Taking this, I'll also reorder strings a bit in a more logical order and add some comments.

Comment 4

[Francesco Lodolo [:flod]]

Attachment: Bug 1396000 - Remove unnecessary line feeds in aboutTelemetry.dtd, remove unused strings

Also reordered strings according to the order they appear in the template.

Unused strings:
* aboutTelemetry.showNewerPing
* aboutTelemetry.showOlderPing
* aboutTelemetry.archiveWeekHeader
* aboutTelemetry.filterText

Review commit: https://reviewboard.mozilla.org/r/175450/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175450/

Comment 5

[Francesco Lodolo [:flod]]

While reordering strings, I found 4 unused and two hard-coded ones (I'll file a follow-up for that).

Comment 6

[Chris H-C :chutten]

Comment on attachment 8903674 [details]
Bug 1396000 - Remove unnecessary line feeds in aboutTelemetry.dtd, remove unused strings

https://reviewboard.mozilla.org/r/175450/#review180564

Seems legit. Thanks for the patch!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0f8ad9a4c3c
Remove unnecessary line feeds in aboutTelemetry.dtd, remove unused strings r=chutten

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b0f8ad9a4c3c