Closed Bug 1396020 Opened 7 years ago Closed 7 years ago

Expose hard-coded strings for about:telemetry in aboutTelemetry.dtd

Categories

(Toolkit :: Telemetry, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: flod, Assigned: flod)

References

Details

Attachments

(1 file)

While doing bug 1396000, I noticed a few localizability issues.

Hard coded 'Home' in the sidebar
http://searchfox.org/mozilla-central/rev/51b3d67a5ec1758bd2fe7d7b6e75ad6b6b5da223/toolkit/content/aboutTelemetry.xhtml#37

Hard coded << and >>
http://searchfox.org/mozilla-central/rev/51b3d67a5ec1758bd2fe7d7b6e75ad6b6b5da223/toolkit/content/aboutTelemetry.xhtml#31,33

For the last point: not sure how well the design cope with RTL?
The design doesn't take RTL into account at all. It does lean moderately on Common.css so it might do better than I make it sound, but I remember adding RTL support to interfaces in the past. It's never that easy...
Assignee: nobody → francesco.lodolo
Priority: -- → P2
Comment on attachment 8903879 [details]
Bug 1396020 - Expose hard-coded strings in about:telemetry

https://reviewboard.mozilla.org/r/175664/#review181062
Attachment #8903879 - Flags: review+
Attachment #8903879 - Flags: review?(chutten)
(In reply to Georg Fritzsche [:gfritzsche] from comment #3)
> Comment on attachment 8903879 [details]
> Bug 1396020 - Expose hard-coded strings in about:telemetry
> 
> https://reviewboard.mozilla.org/r/175664/#review181062

Thanks Georg!
Pushed by francesco.lodolo@mozillaitalia.org:
https://hg.mozilla.org/integration/autoland/rev/827fae5a03b4
Expose hard-coded strings in about:telemetry r=gfritzsche
https://hg.mozilla.org/mozilla-central/rev/827fae5a03b4
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.